Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2698944pxu; Mon, 7 Dec 2020 13:11:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYG+9sxR9xjoupjqtuKBaNAFSxuLTz48FuRCpkqk58eDv6h/sb1aVUR+5kN92rGEO5V2eo X-Received: by 2002:a17:906:f85:: with SMTP id q5mr20617072ejj.105.1607375511663; Mon, 07 Dec 2020 13:11:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607375511; cv=none; d=google.com; s=arc-20160816; b=HVTHTonnFhkfN6O20pi5V8A5rBCrJfZDn6ipcZsv7ibUVn+zVpe6L9+bHlwYKJGEF+ cL2FEIwEGUnQWfasvPCE6rNOvkc4d+ud3BAEcFR3TvLujNBzKpyhBfFwoTIIU86wDv7X Fqab04GI8OlTQOFhpnQRvyWK6riw/BB/JsrgtOF2auaQYw6cTT8mfkcufapNP2zExuUR 16Uqk4c0e3S2QtkY/K3DiBEn0I5GdoZG8J3KzizU+osBSJSrLQ6XB6+W3uQ4BDtgRKRR iSf/tFgkwk4dlV8UmnuYz3iGrzaTqjr+W6d4Ci1ZKvvlMdJEz/7yzcD4+m0Ea53tlmcE 1C9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:dkim-signature; bh=NmTBIYR5a7GHek/f1Tc4SvMiMP/uXzmkTt8oc4bEM8g=; b=mkAMWrX3+gZaml60yrI8YVuk95Oje8a5av8pzDAWoFUh77GebvdkOMZ9Lw+GPZR6cx bAx9eIchzibKVxZeNz0krlX9knqGIRex+zNegRWXOv29s4VKlH7bRY5ElxxJ507DkOEr NmudMFvJBmZ1UVqZtRDxLIrV+iz/G2/IMKaSM/37BdeK98Y74wAMnLndqFzhsQEseDab ILeudImqv5fS8AlL4erkPqjX3oi+G8k/aG9jIZVZJkpbvuyhsFJfN/qnE5ovNkDGb6Fo mo1d21HI5ZpcspCEPjiTuJfkYZ3q5jeD1NcnO5DMyJnBeB7siF2Sr78M4wnB2axa6iUc ET+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AfJ8l2FR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si7137155ejw.380.2020.12.07.13.11.28; Mon, 07 Dec 2020 13:11:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AfJ8l2FR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbgLGVII (ORCPT + 99 others); Mon, 7 Dec 2020 16:08:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgLGVIG (ORCPT ); Mon, 7 Dec 2020 16:08:06 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16D2C061749; Mon, 7 Dec 2020 13:07:26 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id y74so16990511oia.11; Mon, 07 Dec 2020 13:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=NmTBIYR5a7GHek/f1Tc4SvMiMP/uXzmkTt8oc4bEM8g=; b=AfJ8l2FRPARTTdoMFkfnoCHnLIt4cPht3SzEqokTiewfEZXMfO2lZ83KI2sY/4u+WF re+qMYqwJAwshAEomPRi0L3ZE6sgfL565WS4P2k1l7EYkbvylo3OG3su1amI9QoUVmtI uiMpUiq1vBkoQ8y2riJMTz6vbu/RA2PWdYSrll7w52UFyQICTvGuqqo23kiWMnnhnD4n LM1NLXGngpJ8vMmRSUB7IyhBeI4CXPwoBGVa82hpdSOAWy72g8bwwB4elx4q6HaMx9Fi uGV1tL2TRcXZCTQYfuHpYVhYA2T/mBzbEbjEotFE4v/CN1bl3/rGy4w6NnvLrM9UdYdV uaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=NmTBIYR5a7GHek/f1Tc4SvMiMP/uXzmkTt8oc4bEM8g=; b=BkeH0elXU/NRSdDVSoheHIUimTIEopquHeL0UUGaPi5uZdq6J9kps+a0SfK0LzuXWJ 3ywieS7jls/bIt6P0TUaSDGlLOoU74LYjDjDXMvyaV1JClj/3gxb8B2BuRVMkoPG/vjS VX7mhtcsHgBRYc0UrVURsJp13opfEb27okomjdRuap6StXRkvIy6dYy3SlXs6IADrPQv IU8LJFd/KVHrLOi7o0o2PJ5FdibHoQ8XEln811Z5d+hcx9g7/ZNDbnw7QteG6SaTjfam 35OMNh71wQ56t3N7odySEtm8BJb8cM4HmpOFxwjzkdXKcA9+iXurKY7aaBKR0uukR0SH +APg== X-Gm-Message-State: AOAM530TW0n4oqSqNZp+jHnIKSGFCJVOieM3ELxFDfDiOu7wy/xa1ZGS ZBi6m5CYEM6j3I47Z9xJf1w= X-Received: by 2002:aca:5e57:: with SMTP id s84mr542079oib.102.1607375246093; Mon, 07 Dec 2020 13:07:26 -0800 (PST) Received: from localhost ([184.21.204.5]) by smtp.gmail.com with ESMTPSA id z14sm546150oot.5.2020.12.07.13.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 13:07:25 -0800 (PST) Date: Mon, 07 Dec 2020 13:07:19 -0800 From: John Fastabend To: Brendan Jackman , bpf@vger.kernel.org Cc: Alexei Starovoitov , Yonghong Song , Daniel Borkmann , KP Singh , Florent Revest , linux-kernel@vger.kernel.org, Jann Horn , Brendan Jackman Message-ID: <5fce99871ec8c_5a96208eb@john-XPS-13-9370.notmuch> In-Reply-To: <20201207160734.2345502-3-jackmanb@google.com> References: <20201207160734.2345502-1-jackmanb@google.com> <20201207160734.2345502-3-jackmanb@google.com> Subject: RE: [PATCH bpf-next v4 02/11] bpf: x86: Factor out emission of REX byte Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brendan Jackman wrote: > The JIT case for encoding atomic ops is about to get more > complicated. In order to make the review & resulting code easier, > let's factor out some shared helpers. > > Signed-off-by: Brendan Jackman > --- Acked-by: John Fastabend