Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2720441pxu; Mon, 7 Dec 2020 13:52:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJza/iXbP68xT3WTBDpL+4MZxZIsH5ytHSiY+nZesEMwrshLR4/S+qOU+f+qI7fTWSeaKFpF X-Received: by 2002:aa7:cd71:: with SMTP id ca17mr8193769edb.25.1607377944320; Mon, 07 Dec 2020 13:52:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607377944; cv=none; d=google.com; s=arc-20160816; b=LaoptfPTCfjy+iL6WwNyB9d0X2PI4Wi90vgX9XoJEVMNveaywy4+P7R03IL9vGD6ZQ zJSs8xgPUySLDbJirmC2Pj6h7ChzrFRDZ6H8QuxAWvwDEc8R/tKhMWI9BdhCcxJ9sAqi Be5/0oedRTb5a4NWmR2sO3tLo/n5QxBzxLY6pUqg+3HmiT9iNIIxO38V7oRpnb+3YZzK Pi1kDmjeQkfWYl0iHtvH/LQ30HQm/ajOW/hdrA61QpWyzSb8wvhK5/rKf2daWXaL1C3y C5CP61dd/PmmoW2mypXWJSzwcU/xX7NijFlMl+EMn35He4dS9h/cA0yuMZ0CyOrBaF4c x28w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=XezsoOvo1QH3xJ+aBZ86D9VZCPnhkhJ5Z+Xl0ZlweKY=; b=Dt3IeVAYbVHbCqPNqsAdWiujhTiL4U6PhDWifY4XY/ErUL2bywlpKmZHioRL6lGAkd 4gTVTILCcMKz52B2Zkg7tbFQAia7ne3mO+fqklODEiRkLwWKxl9bIkFR9TvU229VCDWj n6tFhkeP7caInBA8sh96iMXK48I4laLJGqpvbNVLd1JZrl/9zgvE9zlNQOHBNJOhOaft onUntExeh3wedSD0B47sCi78GDuvSTEMGlk//vD3Jn+5s8U2mX2egIo4eoTFdSyZI9QJ Yi50i4R903cSLH3LN1pildODSKkPV3xOL7Y/G26hhFwPW1yd5LRpeK7nIR1iqVNJgp0v oH+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ou/lhMrI"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=GWn3H1bK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu21si7332675ejb.81.2020.12.07.13.51.41; Mon, 07 Dec 2020 13:52:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ou/lhMrI"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=GWn3H1bK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgLGVrV (ORCPT + 99 others); Mon, 7 Dec 2020 16:47:21 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:38994 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbgLGVrV (ORCPT ); Mon, 7 Dec 2020 16:47:21 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1607377599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XezsoOvo1QH3xJ+aBZ86D9VZCPnhkhJ5Z+Xl0ZlweKY=; b=ou/lhMrIJDMZQDwxidg5VuFXnC6SB9N3++ayblAcgNHcU1eZumhu759vJrBAc7pU5IPzO1 vXs1lK/DFueDOXyY+rRnXaKB/vC9f3upDubBPRoaC4EEqN5azaWAr/9lP5rhh7e5JVb6Ok pzs6ARW10Iu+x5GTcDsxZUxN0dp78Cw1Tbo1zfN8aWUYopEjJYAyuDSDBrXOWA4OSb/ixQ UGHqYIQRaWuDxPRKXqB8C1RyWoLBuTpV7egnO+MTuHrviHuy9CGzrYBYwZ4S5z8PM3Ur2+ I0QmBB6HRGXbN+xk4iMiq9bcm0Psm8fr4lhVOnlKdhJo4WY/AQ0o5GvMgW2KJQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1607377599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XezsoOvo1QH3xJ+aBZ86D9VZCPnhkhJ5Z+Xl0ZlweKY=; b=GWn3H1bKeJVhH7CoxtzEyz1N8YeBWYN6HyCfmRvWB91JLgmHXvA7vj/Lc6pfeOHjXHZc48 ZHFsL3NoRj+tPpCg== To: paulmck@kernel.org, Marco Elver Cc: Peter Zijlstra , LKML , kasan-dev , Ingo Molnar , Frederic Weisbecker , Will Deacon , Naresh Kamboju , syzbot+23a256029191772c2f02@syzkaller.appspotmail.com, syzbot+56078ac0b9071335a745@syzkaller.appspotmail.com, syzbot+867130cb240c41f15164@syzkaller.appspotmail.com Subject: Re: [patch 3/3] tick: Annotate tick_do_timer_cpu data races In-Reply-To: <20201207194406.GK2657@paulmck-ThinkPad-P72> References: <20201206211253.919834182@linutronix.de> <20201206212002.876987748@linutronix.de> <20201207120943.GS3021@hirez.programming.kicks-ass.net> <87y2i94igo.fsf@nanos.tec.linutronix.de> <20201207194406.GK2657@paulmck-ThinkPad-P72> Date: Mon, 07 Dec 2020 22:46:33 +0100 Message-ID: <87blf547d2.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07 2020 at 11:44, Paul E. McKenney wrote: > On Mon, Dec 07, 2020 at 07:19:51PM +0100, Marco Elver wrote: >> On Mon, 7 Dec 2020 at 18:46, Thomas Gleixner wrote: >> I currently don't know what the rule for Peter's preferred variant >> would be, without running the risk of some accidentally data_race()'d >> accesses. >> >> Thoughts? > > I am also concerned about inadvertently covering code with data_race(). > > Also, in this particular case, why data_race() rather than READ_ONCE()? > Do we really expect the compiler to be able to optimize this case > significantly without READ_ONCE()? That was your suggestion a week or so ago :) Thanks, tglx