Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2728114pxu; Mon, 7 Dec 2020 14:06:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1sbk2tTo2GQ3V79jvoWQnir70QtSBfiZrJZQyDw8a7LqAGNMyewmDldB9OP+GCKBufzb5 X-Received: by 2002:a17:906:2850:: with SMTP id s16mr20179918ejc.276.1607378795110; Mon, 07 Dec 2020 14:06:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607378795; cv=none; d=google.com; s=arc-20160816; b=d8vLm2+h6XcamEeVPl55okhUT2K6jwkmFz+mzbNd0AhmzGaT4KutbnATGat56YsUOg +YtqTOBSVirw2CtRAsWI6j2VS4NdfiRihoYFXhONV8ucA7vh5rn4qXKTryugyP+Y8xKb UyRbZhbGWSu483/OApbgQqVAFK30BcVRPfoFYSaOCd5TRQh+lwV7w9vuQK8alrNPLRfR mL1C8bEfy6g8My97WjJ24qpm/bATRO1BSUzd2qmnw8wUSJHs0qGzR2NMRmCVtNixOBNQ Jt3KPbCP6azP6ZrvZzW0pbswnbeG62ekhgPxHH2YGgHvu58yXEW1S+H3riiwPkm9Otgx XsXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=Ss8WaLcdokkmrrcznGv29pZQDMMRYrY5tuFVliI7mtk=; b=Eo1Tc2X97yjcV+IQhBro7EZEVEa6YtOklblqbvDKqsCzaujiuY2/JFMtkXygknf4+l 8O5zFMyLNYufn4eVLV5BL1g6YMBJSKEjNvXC+FxyHb7LrIYfF/HG3pL2NZClYav/xdB7 u8ho+SPgYhLXMqYndU436HvZ3J9swnwjkfvY1Qqj1uwLyKPgZ4691k1QLSz4gBIG3rAz tAXOtyQBnQo6LLaiiVSxQIZka/gabRAruSaysGVUnudLDsyLPNE3zMGZQii/9AoNrHhZ Ehmr8Bv3UGfahagBuvO6xGiA4MOZY6PUkMF+F+RD6JbjusE/iXr+CEgcH9BW3EmuaLAr 77Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=PBo4wGrW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l16si2189408ejd.683.2020.12.07.14.06.11; Mon, 07 Dec 2020 14:06:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=PBo4wGrW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727831AbgLGWCr (ORCPT + 99 others); Mon, 7 Dec 2020 17:02:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgLGWCr (ORCPT ); Mon, 7 Dec 2020 17:02:47 -0500 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0CDC061793 for ; Mon, 7 Dec 2020 14:02:07 -0800 (PST) Received: by mail-il1-x141.google.com with SMTP id x15so13734647ilq.1 for ; Mon, 07 Dec 2020 14:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ss8WaLcdokkmrrcznGv29pZQDMMRYrY5tuFVliI7mtk=; b=PBo4wGrW4sBGEHPUF7gOtM+tS0xrZECiPlkWeruaBNoiyEg8pGqn1wVDB32B6JGzlR D8BOLrzFapLOmsbKoUkwfzwU+K4vIjzzPrI2d6yUfkWi7WKaZZT+8lFL/mpiqqcfu6QU xFY3OGWDHmtNuPnZgGh8hXmOLCxvA9kv0xpwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ss8WaLcdokkmrrcznGv29pZQDMMRYrY5tuFVliI7mtk=; b=QRVYwUnliZpHnEaxLsbR8DEdoUi6Vk/+xCjV99Yaf3FWcdpdA4di8eSCnjA5I95CzD zCdFPkrK8NAnw9Tu7ckeOj3qTxNznBRbqBqSXCaZ7sqR51iSISnbSD9gELips1tHEFCO E2R1o+EDuB/AbBVyxXUmph79JFflFP3LPwZAjAcoQBSGb0GaBWI36by1gt5WZuX70Qdl ahFW6hRBseYyjTIvDfKSoQ27GVSVDnUB/qPHscpxtAc0Vi4pQDByiGP8M+eGO7knmuvy Y/UAJzEI9kPgzaF7EYyl/rySqLsjcNncOulz6tJH6Gvi8dlJahMsQ1zqvtBHdESmBsIR hTKQ== X-Gm-Message-State: AOAM530llkvNetO7KvfIt1bE0cfl5oNA4YY96Br2gjpOLS51pMLxSCdq HnrIMuYoLJ8VCOyYhvj5VQkI1A== X-Received: by 2002:a92:ac08:: with SMTP id r8mr3961124ilh.166.1607378526701; Mon, 07 Dec 2020 14:02:06 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id h15sm6726176iow.13.2020.12.07.14.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Dec 2020 14:02:05 -0800 (PST) Subject: Re: [PATCH v2] selftests/clone3: Fix build error To: Xingxing Su , Christian Brauner , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <1606447017-10640-1-git-send-email-suxingxing@loongson.cn> From: Shuah Khan Message-ID: <22c84b2d-2a1c-8947-c217-27888bfbcd51@linuxfoundation.org> Date: Mon, 7 Dec 2020 15:02:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1606447017-10640-1-git-send-email-suxingxing@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/26/20 8:16 PM, Xingxing Su wrote: > When compiling the selftests with the -std=gnu99 option the build can > fail with. > > Following build error: > > test_core.c: In function ‘test_cgcore_destroy’: > test_core.c:87:2: error: ‘for’ loop initial declarations are only > allowed in C99 mode > for (int i = 0; i < 10; i++) { > ^ > test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile > > Add -std=gnu99 to the clone3 selftest Makefile to fix this. > > Signed-off-by: Xingxing Su > Acked-by: Christian Brauner > --- > tools/testing/selftests/clone3/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile > index ef7564c..88354a8 100644 > --- a/tools/testing/selftests/clone3/Makefile > +++ b/tools/testing/selftests/clone3/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS += -g -I../../../../usr/include/ > +CFLAGS += -g -std=gnu99 -I../../../../usr/include/ > LDLIBS += -lcap > > TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \ > Applied to linux-kselftest fixes for 5.11-rc1 thanks, -- Shuah