Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] selftests/clone3: Fix build error
To:     Xingxing Su <suxingxing@loongson.cn>,
        Christian Brauner <christian@brauner.io>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <1606447017-10640-1-git-send-email-suxingxing@loongson.cn>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <22c84b2d-2a1c-8947-c217-27888bfbcd51@linuxfoundation.org>
Date:   Mon, 7 Dec 2020 15:02:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <1606447017-10640-1-git-send-email-suxingxing@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/26/20 8:16 PM, Xingxing Su wrote:
> When compiling the selftests with the -std=gnu99 option the build can
> fail with.
> 
> Following build error:
> 
>    test_core.c: In function ‘test_cgcore_destroy’:
>    test_core.c:87:2: error: ‘for’ loop initial declarations are only
>    allowed in C99 mode
>      for (int i = 0; i < 10; i++) {
>      ^
>    test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile
> 
> Add -std=gnu99 to the clone3 selftest Makefile to fix this.
> 
> Signed-off-by: Xingxing Su <suxingxing@loongson.cn>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
>   tools/testing/selftests/clone3/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile
> index ef7564c..88354a8 100644
> --- a/tools/testing/selftests/clone3/Makefile
> +++ b/tools/testing/selftests/clone3/Makefile
> @@ -1,5 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -g -I../../../../usr/include/
> +CFLAGS += -g -std=gnu99 -I../../../../usr/include/
>   LDLIBS += -lcap
>   
>   TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \
> 

Applied to linux-kselftest fixes for 5.11-rc1

thanks,
-- Shuah