Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2739100pxu; Mon, 7 Dec 2020 14:27:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWbsvmFk1JZmv0gk/XxnU+1efW1A3Z1sTlGP/6YMdKODhbY7CLfn1LulccQ4vFbqBGuZ0s X-Received: by 2002:a17:906:3949:: with SMTP id g9mr3481340eje.493.1607380056133; Mon, 07 Dec 2020 14:27:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607380056; cv=none; d=google.com; s=arc-20160816; b=vwm4hERMsFZ6u189uQRX/mQKVv4dLsE6DwXIa7kP+lpmlT2FCEhUJ63uIcFEJlAC7I jDgSOVxGZCBD1T+94gFPBfct3/eMSb6evEVrpM4ShkXD0VDYxVU4kt1XjOfRaURNsm5B 3domowR3oDLC5CuAFjyvQ2ONm4QL4gRFvBsqHxXKZnOMtIpgrQEFxlY8nW4Rv1V5oHfl YTqCwCrnjUXE4m5dt6ff4nkNxqpzYLpy78kbeh+hRmDVCq16VowEWscNniYbYbXxIlq7 v6V4DBjJr/o5W/+MT1Tob7jRE/DgYxDtfjHpxVCwdJQpsij6TXQV5QoQQImPMfuarkx4 bSFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=914UG8zVh6HNKad8qFgbFphbya57JgSOcPMsayoR1GE=; b=QdAONPruS7zx9IFV7ZEviklp2ZGPpEKTasQK5vCE/QAfrUbzZWAF1qhCXPuXUi2fS3 AVfxRueyWt/ED2h9gvJe903UNvHMCnoUchTbEmsQoseBBuz/atofe1s5v83LVKuV2NvP hMCM9brO3ZpjP2Pp7mR4R/vyt5AxcqZajMKHq4RE3qjrNQSd665EyWfXMAkMVmGQViqH JaOaKN2+Y53l5YBvV3fh9Fd5ZoL8A5ACgc3s342s+LCTPDxapouiiuYmaAEUIX/9KDfl d6boV2oelMCSgWIsFerP9qGD/LH4KIbz+GY+dnym06IGyRPk2kZk7WFfpPDbFHOXY0PZ SXbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=jpxOFeVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me16si7124893ejb.257.2020.12.07.14.27.12; Mon, 07 Dec 2020 14:27:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=jpxOFeVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgLGWZZ (ORCPT + 99 others); Mon, 7 Dec 2020 17:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgLGWZZ (ORCPT ); Mon, 7 Dec 2020 17:25:25 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F665C061794 for ; Mon, 7 Dec 2020 14:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=914UG8zVh6HNKad8qFgbFphbya57JgSOcPMsayoR1GE=; b=jpxOFeVCKHWgoJk6iNbawQlXFQ m7nHYI2xN0ye5GEnc5MAJ0crJ+am9aqfkjnsqMSuCcgrCf5sjPcA4Uv7Lzpfk0oyvjxtnWfj7pjii TgkVd2RL0k1UYQ4APlAdk+D4Hct0hb5NpgQTXdSEbdA7og6d8J3pkfOJTthMg+8YPDWvmQnZ148T2 Of2kYPZpn5wEphmqHotVZVAEBaOajllVuNE0q0dy3I7rv+FSDODHNzr/NdJT6GA5SuPatxqhx5Abz IewcVRzGyqFGoHpOgeZjFzpmgJHB+pMp81r2IBXrCXTVfREHIHglCbJF3g6hnR+DzEn5TxmNEEN6e ULBzeTJA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmOvl-00075i-Jp; Mon, 07 Dec 2020 22:24:30 +0000 Date: Mon, 7 Dec 2020 22:24:29 +0000 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags Message-ID: <20201207222429.GC7338@casper.infradead.org> References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-8-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207220949.830352-8-yuzhao@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > Move scattered VM_BUG_ONs to two essential places that cover all > lru list additions and deletions. I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have to take that extra CONFIG step to enable checking them.