Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2852659pxu; Mon, 7 Dec 2020 18:26:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSNe+PfTy6UhzOt5vHM6NZP4Zb2XwR6enl8+rLGslZA3rVwcpOcIXhbpgdwgIg5i6EEDuG X-Received: by 2002:a17:906:d62:: with SMTP id s2mr2124164ejh.61.1607394367366; Mon, 07 Dec 2020 18:26:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607394367; cv=none; d=google.com; s=arc-20160816; b=EmEDgJ2tsWtAoM1mNhiyqwJi4NYCLH1iS2w33HM8QUoRaYuwUeWkCDyQVW4x4QGExq +PGcY4aSjonjjW5VXEqge1UTJce9jl43fevyVZhApYp9XqHY4e/hU9DAxjaGm9NwstSM BGHsCnoapC1LiYtQa0feXqj+Ayzt/IEkqVaIKutS2kLIywqZF5Mg9ZgO3Cb0Hl9QCfCv 0HBgGv54g1z+UQuRCFD5KoJvGSv42cp4YUjqobksHmi+OoIzvdFvgT4qa0Hf3QkgiLeI 2OfHzStL1bq5WIsvXeBWrRZ/2B7J+oJo/5CJd0qWWDGZKF+gT/Gx05xgJVAa+/EHMsC0 a2Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=HLSD9g8DUFWHfp3CBRo0CnDXe55Yme4VqSPtT3biIu0=; b=Xudwc2VCbgkGq+oIrVOX/9lWfY/7iiWvQ3cxUDcgAQqWtB6kqz/Z6D0RbFMqymVmyJ LdwVTUOu84Jd696/4Qqw8ECspVJilQjwpL024VLAflGDPXymYrSyUkt67tu0QT6CQcDA vU7uD9BgSYoJq8Zwfv452pepwM4l4HkRqzCy93C2GF0n4fDorViWwQSj24Ze7TKuBaWt j/WJ1gR4fWiMiBUKyl1LgG5KoCDKze9z2e18biiFHuVk9zzy0D0AOkuvXSe4UYip3h3a fmVi/0LacN4Y88gvkTfTRO+BqaD2CCNFy8xtuBidi9NHGALUWLwZXxELp+tbExF9XPyo KGkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bm1XVYpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si7301001ejp.666.2020.12.07.18.25.44; Mon, 07 Dec 2020 18:26:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bm1XVYpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgLHCWs (ORCPT + 99 others); Mon, 7 Dec 2020 21:22:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:35144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727963AbgLHCWr (ORCPT ); Mon, 7 Dec 2020 21:22:47 -0500 Date: Mon, 7 Dec 2020 18:22:06 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607394127; bh=bsexMs+QLMd00yUiO/o6BDQs4h2Mkb5Cc6l7Vc16tdQ=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=Bm1XVYpHH/f1Lqs92TK/I1Eco2jjBywkXjMCHdmnpsjNL+9jFXEll/mbQEh+2eKPL Jfn0CVf4gGhQ9PMIlskfmyQUZgQOuAJfa5uEcC0fdzgXotyrPqqe6dwe9WkRtFXYGb vOwMujgw40Gm3qTK8ro7lW4HBWzVX2jyvyl152iOHqBeJCoG7xSQsSjGjqo9jL8Ya8 mw5HbaegFvIiUfnWEtNAIoCV7KJxJoPQ+VaUfaC0vHXjsGZD8lLQalp4qH5argRJJD Q6bcW6Vb66gLsQN45F8xnQFvTG+pBInMhaZ5JiKMRimRZwUt3moIEFvTkNE5JnT/OV aKTdJ2jKzddpA== From: Jakub Kicinski To: Jarod Wilson Cc: linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Thomas Davis , netdev@vger.kernel.org Subject: Re: [PATCH net-next] bonding: set xfrm feature flags more sanely Message-ID: <20201207182206.572acfaf@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <20201205174003.578267-1-jarod@redhat.com> References: <20201205174003.578267-1-jarod@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Dec 2020 12:40:03 -0500 Jarod Wilson wrote: > We can remove one of the ifdef blocks here, and instead of setting both > the xfrm hw_features and features flags, then unsetting the the features > flags if not in AB, wait to set the features flags if we're actually in AB > mode. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Thomas Davis > Cc: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson Applied, thanks!