Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2946284pxu; Mon, 7 Dec 2020 22:22:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWLjILqc5S3SZAWe/KoVEBxkg5C3hcjKFpAzqNU3ECup6tYY6HyGsqQgU7PAF85zZ4fUK/ X-Received: by 2002:a50:9ea4:: with SMTP id a33mr19842569edf.70.1607408523346; Mon, 07 Dec 2020 22:22:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607408523; cv=none; d=google.com; s=arc-20160816; b=0mxFPPn5mO8POzumNZUAeEj02OzuDLWDs+esPme0/lDJC3PrxQwU26XGFLx2sIZeQI qAyVGy5qtEjFm/zQswJRk06uaCzxxfBXVb9JNy/hHW2fnVpBNoUZxldebfRYGk4RVLI6 4zVkfrIO+49EliPO43RVqyABlG6H06OQQL+YpnUfL8uTCpWPvYJvBCLKnATQNd+JOuAq oDdiczDNsRQOAhXsiEOGmugNciEsfl1tF/iEFm4LQVSfLAAcmISaTvq3lwmPovCg5zHV u/FV39vkT/suZOH5FTBOkmv8FXN1zrluk9wbmnVE6GvaO6+URwmHbzIAkjwx+4FyhVZN hWTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:dkim-signature; bh=sadeGNSRFPIoFTYVcdnZgjQ48y5NGBk9I5/A99DQWxI=; b=dd4vlqSrhLCK4HIm7jEQsgaVqDtav9RBgLd9Qc4r2HPT9tk4/gVA2ucCf7ri0qSHf/ 7afK+nbIMWxZNkYKX55lwWUqJcm/X5nS22m3/5OieQ1H/FMrItgL2DALcUNZvykmKuQj Im5vGM3YYiHgIbicdwhQ7M8DlhKmAI83Ns4jcpeF6Z5x4V81P751AgF3lC/0Hytaq362 KR0EOC6jbx7ApeeF+Fv7Rle0VAuqjtHi/JkDT77V19ekoQ5WWP2YM2YkEu0otqE5CVyz hUlxHOuG5bsrBMIyvny+8zQWCh5C9JMP+SenER3UPQtOOOUiBIb0JePxCQgovq58ifY9 r4uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cpVQ2N3U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl4si8309243ejb.642.2020.12.07.22.21.40; Mon, 07 Dec 2020 22:22:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cpVQ2N3U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726391AbgLHFOd (ORCPT + 99 others); Tue, 8 Dec 2020 00:14:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbgLHFOd (ORCPT ); Tue, 8 Dec 2020 00:14:33 -0500 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F30A5C061749; Mon, 7 Dec 2020 21:13:46 -0800 (PST) Received: by mail-oi1-x244.google.com with SMTP id l200so18176594oig.9; Mon, 07 Dec 2020 21:13:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=sadeGNSRFPIoFTYVcdnZgjQ48y5NGBk9I5/A99DQWxI=; b=cpVQ2N3UgmfVIMaW6R2J3zD6cpcTbxMKt3p989Si/sfb4z4ZV7G7BW8MahYbrh9NXv vWP0ADO22BMuB+0IzKhtV78tueAQETXob4RzsVu9nPlYCgHY5T4nWRZNW8O+nnYHIrzv xvcaaUka8DfQzoK26lm2xSO9IUCOoIX5UNeLzuxLO0CZrlmTRzTvAQrlABeNmO97Z9TS AH7ZVil+/KwsPA5SXsijirdQWsh5E4YG7fAwMp8Crcxgn5o0KIbLdQpozumJWUFDBqmT qsLt/ejhpH23deonD4c1081rIQXY8l1IH1e7Lh+x+cEJ/EtBYeUQ8qPhYV+ggL5g8pSV jNSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=sadeGNSRFPIoFTYVcdnZgjQ48y5NGBk9I5/A99DQWxI=; b=EhSmINKde7lSdtTfhZQKAqftnrgm/M737GSJkanJfQgWbaSlMfXierN3r/jjNoHRbv 9N5wT23Wb14bMcYaW5gU/LFvq2OcXOyLkkJoz5Zv/w0oR0BLdKOioUkAq9NkdvsoEgNm wEEeY2OQSgbLmrUuylzZM5bRr/nbvsScWA9gV6EfPb2icID6JX/JgZTzJPOLigTsojTl jQCcd9tFuAbMzqTgjdQ+5hWpzQlvWQJR0PlBaZTUhh4ApvDIPTJylqYDvXm4CrtUmCWJ 41b0XpudlLcot9n14whBVqLFWca40ZOV4nTCFPL34lorM0+CbeWrxNz50x07MwNu+9YL nVZw== X-Gm-Message-State: AOAM531J0nY1I/wbQCSAajHZvnq/YDiiGXIaIm5GLrptaU3+2eBZ7q6R /Sdz1ZXjBz4szq1/5Q/is7Y= X-Received: by 2002:aca:f456:: with SMTP id s83mr1505805oih.58.1607404426497; Mon, 07 Dec 2020 21:13:46 -0800 (PST) Received: from localhost ([184.21.204.5]) by smtp.gmail.com with ESMTPSA id v5sm3131017oob.40.2020.12.07.21.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 21:13:45 -0800 (PST) Date: Mon, 07 Dec 2020 21:13:40 -0800 From: John Fastabend To: Brendan Jackman , bpf@vger.kernel.org Cc: Alexei Starovoitov , Yonghong Song , Daniel Borkmann , KP Singh , Florent Revest , linux-kernel@vger.kernel.org, Jann Horn , Brendan Jackman Message-ID: <5fcf0b8413fe_9ab3208ce@john-XPS-13-9370.notmuch> In-Reply-To: <20201207160734.2345502-6-jackmanb@google.com> References: <20201207160734.2345502-1-jackmanb@google.com> <20201207160734.2345502-6-jackmanb@google.com> Subject: RE: [PATCH bpf-next v4 05/11] bpf: Move BPF_STX reserved field check into BPF_STX verifier code Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brendan Jackman wrote: > I can't find a reason why this code is in resolve_pseudo_ldimm64; > since I'll be modifying it in a subsequent commit, tidy it up. > > Signed-off-by: Brendan Jackman > --- > kernel/bpf/verifier.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) Acked-by: John Fastabend