Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2986553pxu; Mon, 7 Dec 2020 23:53:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJyk9uTV1zv9BjpCEms6uwFIh/LzwnMbH+DMrwHU81/6QK73PGcW7sBaCxPhdynB1g8iMj2U X-Received: by 2002:a05:6402:1684:: with SMTP id a4mr18562020edv.348.1607414008952; Mon, 07 Dec 2020 23:53:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607414008; cv=none; d=google.com; s=arc-20160816; b=E42U6VsCQOI5xq/hiJjlrEQOPfx/1Z+shMbN41/tzUYaZ1Dy4qOutuM+QGja0T09hs D4Q2SQRNWdXmpYolR6iuwz/TdX1bOaG/O3dt4qyS3A0acqNmpN5jVk5dWbDQoU0weApa BHTpTcqlsy55b43dvxl+uv/zXcGm4xwiV/aGX1zvtjWIIQXQCaxTXs81FplXhiSWU3oM ojneX1PmJDSg4X+8K75pizsEhwxV3aJchMgKJWuHPdgwCygR1C+d2lD9BaIRoRKoiHYZ hSw0JW/LfQfIvZKQfOUyeKp+yuVKwIZdh3Aa99R3wZ7cKG3AO2w2r7x8xxagMxQ2V0x3 pd4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=gD3pOtea5WCf/FmRyhS37fUwlsvJBOxTLhxvGAS8Mqs=; b=kVBUkDpC42nmbNEvgNwlAC152nnTGYesS5llnkquaPGX4WkkyiAiDybVLZUQriKe+i EwP7bU31sTkZb8FDuxPk1NWgvwYuQvyHY538pazr/lNb4KAYT/bp4lh6CNcXo5iuigWa cMhBcbvSsf5AS54h9ieG8hLSlNwfJuaEp7+epgze90iLRpJGWfNad1p3pxBDe47UHxwC EOwb9/V+NHkbovpAk6e4fkcrn74Lc3jhrYrksZk38XUbVrpxqJebUtRtl9khumujxetf asuvOGUwBGf3mmhlH2sKO5vlVGKPm+lXmFt4zjontS4YNkgUDtY8MUK5YCBIoI5qkA8c H8Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx6si7789435ejb.550.2020.12.07.23.53.06; Mon, 07 Dec 2020 23:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbgLHHva (ORCPT + 99 others); Tue, 8 Dec 2020 02:51:30 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:9394 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbgLHHva (ORCPT ); Tue, 8 Dec 2020 02:51:30 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cqsm85g5Vz7BCm; Tue, 8 Dec 2020 15:50:16 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Tue, 8 Dec 2020 15:50:45 +0800 From: Tian Tao To: , , , CC: , Subject: [PATCH] drm/tidss: Use the new api devm_drm_irq_install Date: Tue, 8 Dec 2020 15:50:59 +0800 Message-ID: <1607413859-63365-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_drm_irq_install to register interrupts so that drm_irq_uninstall is not needed to be called. Signed-off-by: Tian Tao --- drivers/gpu/drm/tidss/tidss_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c index 66e3c86e..48e1f9d 100644 --- a/drivers/gpu/drm/tidss/tidss_drv.c +++ b/drivers/gpu/drm/tidss/tidss_drv.c @@ -173,7 +173,7 @@ static int tidss_probe(struct platform_device *pdev) goto err_runtime_suspend; } - ret = drm_irq_install(ddev, irq); + ret = devm_irq_install(ddev, irq); if (ret) { dev_err(dev, "drm_irq_install failed: %d\n", ret); goto err_runtime_suspend; @@ -219,8 +219,6 @@ static int tidss_remove(struct platform_device *pdev) drm_atomic_helper_shutdown(ddev); - drm_irq_uninstall(ddev); - #ifndef CONFIG_PM /* If we don't have PM, we need to call suspend manually */ dispc_runtime_suspend(tidss->dispc); -- 2.7.4