Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3016114pxu; Tue, 8 Dec 2020 00:55:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0PHzqVa9Oi4MzHPuD2A5PcnNDikslu8QCt5g4TjZ1RHug6VzCa2g2+xd0xatc8CBZwCj6 X-Received: by 2002:a17:906:a182:: with SMTP id s2mr21486152ejy.249.1607417710819; Tue, 08 Dec 2020 00:55:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607417710; cv=none; d=google.com; s=arc-20160816; b=sRM+YQB/H5fQEZsH8NL5BL5IsQV1BL8l74r/pd2njtZ2+2n/0f+r55dD8/zHOjYRNX pzRIS/fhsreiYzUsr5hAoPSzyEx49WL2xptpdfPxJhF+GXW/qf+RrKwt6hCOayVQ8+GK jPk8DvDbOBmGaJlFg9NmIz4e3AJc9Q5/Q+lr0UKCwgt1SqdPlVOyJWLABCSonqIAdnyD tK26Bcwo1jmZamvfiP1BT4BZL9iRO5HRzrOPI6GYOobHwVzBZOJz/rpYJXRi4QbvnHdt 0n+h2KHewifjOokBnEWotSCSBlHE9GlODJ+2FLIVRK9MEuL2lxwjh4asEqiBzhnDrkIQ cDOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+VDKc/HgWVDuQ0H0f8Rxw42QrTDSJT/9yEEn51w8wTo=; b=a3UY2944w6EHyayF9XDXrhgT6UcqnyoLsyMyr/X6KE9s6F157tSjhVnMw2GFGCV7w5 EBBoLdbfzwNgUrV7HcO1g+c/7Ff/NBlpzy9wIgxv1MD6zowKdJX1xFwJ7WBz16TRAQz+ kVh8Z/qROYqUmPF4jCINJAm9t9I4bppzLm5sYABwHkm8Dh43LDrKXxxBWDHecH/kN08E A3fIEvkA/o8IRCo+H4/O15eE0EddPtSkXyTnbNri92owC75zaoASFes7h81k6AhgijN6 /XShdbz1CPXZrrpM2z3ls4Ri/HkCRcf2HONXuqhM5F0Un8C8zBnJ/ovYygg14VgSGnvn 99jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o21si9693203edr.305.2020.12.08.00.54.48; Tue, 08 Dec 2020 00:55:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbgLHIvr (ORCPT + 99 others); Tue, 8 Dec 2020 03:51:47 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9034 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgLHIvq (ORCPT ); Tue, 8 Dec 2020 03:51:46 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cqv5h6TwtzhpPc; Tue, 8 Dec 2020 16:50:32 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 8 Dec 2020 16:51:02 +0800 Subject: Re: [PATCH v2 2/3] erofs: insert to managed cache after adding to pcl To: Gao Xiang , CC: LKML , Chao Yu References: <20201207012346.2713857-1-hsiangkao@redhat.com> <20201207012346.2713857-2-hsiangkao@redhat.com> From: Chao Yu Message-ID: Date: Tue, 8 Dec 2020 16:51:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201207012346.2713857-2-hsiangkao@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/7 9:23, Gao Xiang wrote: > Previously, it could be some concern to call add_to_page_cache_lru() > with page->mapping == Z_EROFS_MAPPING_STAGING (!= NULL). > > In contrast, page->private is used instead now, so partially revert > commit 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper") > with some adaption for simplicity. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,