Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Dec 2020 10:52:00 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Shuosheng Huang <huangshuosheng@allwinnertech.com>
Cc:     robh+dt@kernel.org, wens@csie.org, jernej.skrabec@siol.net,
        tiny.windzz@gmail.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] arm64: dts: allwinner: a100: Enable cpufreq on
 a100
Message-ID: <20201208095200.lkyxqzgh5wzjjz7c@gilmour>
References: <20201208072138.9003-1-huangshuosheng@allwinnertech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="oab6asfbiyrhkwmt"
Content-Disposition: inline
In-Reply-To: <20201208072138.9003-1-huangshuosheng@allwinnertech.com>
Precedence: bulk


--oab6asfbiyrhkwmt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 08, 2020 at 03:21:38PM +0800, Shuosheng Huang wrote:
> Enable cpufreq for all CPU cores on a100.
>=20
> Signed-off-by: Shuosheng Huang <huangshuosheng@allwinnertech.com>
> ---
>  .../allwinner/sun50i-a100-allwinner-perf1.dts    | 16 ++++++++++++++++
>  arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi   |  6 +++---
>  2 files changed, 19 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dt=
s b/arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dts
> index 301793c72cb7..62a770f1a979 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dts
> @@ -21,6 +21,22 @@ chosen {
>  	};
>  };
> =20
> +&cpu0 {
> +	cpu-supply =3D <&reg_dcdc2>;
> +};
> +
> +&cpu1 {
> +	cpu-supply =3D <&reg_dcdc2>;
> +};
> +
> +&cpu2 {
> +	cpu-supply =3D <&reg_dcdc2>;
> +};
> +
> +&cpu3 {
> +	cpu-supply =3D <&reg_dcdc2>;
> +};
> +
>  &pio {
>  	vcc-pb-supply =3D <&reg_dcdc1>;
>  	vcc-pc-supply =3D <&reg_eldo1>;
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/=
boot/dts/allwinner/sun50i-a100.dtsi
> index 8f370a175ce6..c6ff172bf599 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> @@ -26,7 +26,7 @@ cpu0: cpu@0 {
>  			clocks =3D <&ccu CLK_CPUX>;
>  		};
> =20
> -		cpu@1 {
> +		cpu1: cpu@1 {

You're using these labels in the previous patch, it should be added there.

Maxime

--oab6asfbiyrhkwmt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX89MwAAKCRDj7w1vZxhR
xWNKAP4yfCNPd2/4gONFj9eKQi/Z/W1/z27q/e+221eheoo7vwEAyz+y6MQ9jK45
Asp+V8YjcJtbGuT9Dj41JLiO5omV9wo=
=RxVm
-----END PGP SIGNATURE-----

--oab6asfbiyrhkwmt--