Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Jiri Olsa'" <jolsa@redhat.com>,
        "'Namhyung Kim'" <namhyung@kernel.org>
Cc:     "'Will Deacon'" <will@kernel.org>,
        "'Chanho Park'" <parkch98@gmail.com>, <mathieu.poirier@linaro.org>,
        <suzuki.poulose@arm.com>, <coresight@lists.linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        "'linux-kernel'" <linux-kernel@vger.kernel.org>,
        "'Mike Leach'" <mike.leach@linaro.org>,
        "'Leo Yan'" <leo.yan@linaro.org>,
        "'John Garry'" <john.garry@huawei.com>,
        "'Peter Zijlstra'" <peterz@infradead.org>,
        "'Ingo Molnar'" <mingo@redhat.com>,
        "'Arnaldo Carvalho de Melo'" <acme@kernel.org>,
        "'Mark Rutland'" <mark.rutland@arm.com>,
        "'Khem Raj'" <raj.khem@gmail.com>
In-Reply-To: <20201207132840.GA4070632@krava>
Subject: RE: [PATCH] perf arm pmu: fix build error on MUSL libc
Date:   Tue, 8 Dec 2020 18:54:58 +0900
Message-ID: <001001d6cd48$303a8810$90af9830$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQL9yUid8Wz8jDy8suCkHfvhsfGAdwJrg0gYATsEmCsCM/My1AK/Az8hAumiFLSnQuOvAA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20201206144527.1670483-1-chanho61.park@samsung.com>
        <CGME20201207105410epcas2p3f9210689886172422d27870f25a79df3@epcas2p3.samsung.com>
        <20201207105359.GA4198@willie-the-truck>
        <001101d6cc90$3b491310$b1db3930$@samsung.com>
        <CAM9d7chU0SP79cjuZOBg1Rhe2NYaxAOnKzdQ+XQ65fenTzak0A@mail.gmail.com>
        <20201207132840.GA4070632@krava>
Precedence: bulk

Hi Namhyung and Jiri,

> -----Original Message-----
> From: Jiri Olsa <jolsa@redhat.com>
> Sent: Monday, December 7, 2020 10:29 PM
> To: Namhyung Kim <namhyung@kernel.org>
> Cc: Chanho Park <chanho61.park@samsung.com>; Will Deacon
<will@kernel.org>;
> Chanho Park <parkch98@gmail.com>; mathieu.poirier@linaro.org;
> suzuki.poulose@arm.com; coresight@lists.linaro.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel <linux-kernel@vger.kernel.org>;
> Mike Leach <mike.leach@linaro.org>; Leo Yan <leo.yan@linaro.org>; John
> Garry <john.garry@huawei.com>; Peter Zijlstra <peterz@infradead.org>; Ingo
> Molnar <mingo@redhat.com>; Arnaldo Carvalho de Melo <acme@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; Khem Raj <raj.khem@gmail.com>
> Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
> 
> On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> > Hi Chanho,
> >
> > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@samsung.com>
> wrote:
> > >
> > > Hi Will,
> > >
> > > > Looks like other files just include this unconditionally, but have
> > > > a comment explaining why. See util/branch.h and util/event.h.
> > > > Maybe we should do the same for util/pmu.h, which is already
> included here?
> > >
> > > I found below files which perf includes <linux/perf_event.h>.
> > > Instead of doing same for all, we'd better put this only for
> > > tools/include/uapi/linux/perf_event.h.
> >
> > It's a copy of the kernel header, I'm not sure we want to add something
> there.
> 
> right, we want to copy that directly from kernel uapi so let's not do any
> changes in here
> 

I tried to modify it from include/uapi/linux/perf_event.h but it didn't
work. And then, I found perf tool tried to refer the header from
tools/include/ directory. I should go include/uapi first and sync the change
to tools/ directory. I'll re-spin this patch.

Best Regard,
Chanho Park