Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Adam Ward <Adam.Ward.opensource@diasemi.com>
To:     Rob Herring <robh@kernel.org>,
        Adam Ward <Adam.Ward.opensource@diasemi.com>
CC:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Vincent Whitchurch <vincent.whitchurch@axis.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH V4 01/10] regulator: Update DA9121 dt-bindings
Thread-Topic: [PATCH V4 01/10] regulator: Update DA9121 dt-bindings
Thread-Index: AQHWx+k2nPrYkNpltUGZPYQaTY+Kt6nr9TiAgAEQJQA=
Date:   Tue, 8 Dec 2020 10:41:57 +0000
Message-ID: <AM6PR10MB280786E90152D183C8B52454ECCD0@AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM>
References: <cover.1606830377.git.Adam.Ward.opensource@diasemi.com>
 <0606d3ded5fef4c38760246146f197db4ce3a374.1606830377.git.Adam.Ward.opensource@diasemi.com>
 <20201207175809.GA503826@robh.at.kernel.org>
In-Reply-To: <20201207175809.GA503826@robh.at.kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.51]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c00d89e8-9b9c-4052-f199-08d89b65e325
x-ms-traffictypediagnostic: AM7PR10MB3221:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM7PR10MB3221E5D66D02A45AB8878D2ECBCD0@AM7PR10MB3221.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LZgoOoNF1IR0Lo6l13yKtOdpD0HtR3mmYD23T1fVQatTi1teZe4jjWSZe/tRxL500II85VkA1T5SCU9C8BXobSRzqipdK238CZzY+pqd//auUqGbGVZQrmgqe65FKANxY174FQLjOoxJR8kFs+Xa6UJH5vsRrOqdIH99UapvQz3Hp996Msglj+P6+lkWUTA3I6F+3P6XQGl+WJ/9BQaTkjezMLmlV8i3XlRbiSk1UiP4xYTznflYDt1pmLc8N7p86VO2/MpW36gy7bqJOD+h4IYcHCcmDe4UgxjUbAK1LeFa98L3qVw7lVuEX0m1sHsfvaFH614X/ylqrIid6QJlVg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(71200400001)(186003)(7696005)(55016002)(66946007)(33656002)(66476007)(66556008)(66446008)(2906002)(9686003)(4326008)(26005)(64756008)(8936002)(86362001)(8676002)(54906003)(107886003)(55236004)(76116006)(498600001)(52536014)(6506007)(110136005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CRWetWOYiqaxCbtL+QrsgrKxK9yPPZg5aCp9bxr8LC7aH4nUwo1joSZVlp1B?=
 =?us-ascii?Q?/1sPrQQZeveOnNul3mRWUNzrUhDQTvg5gTidDXnK5ZXqQ+u1bplBfDH8WTqu?=
 =?us-ascii?Q?KaILpeAS9hyjO/xOjP7m0lYJ732lcsf9DcHvp75xBI2kxSLAX7X1g0EAbf6b?=
 =?us-ascii?Q?HHnqKMq87aO2pW/R8YnqSk8cKNV3rNp92a2get2y6I9HRpx71zjVjAfwW9CN?=
 =?us-ascii?Q?tLISauxNmKzr7gWHTximw3be/fkmDhB1MyGlnrs0BZFQyGLMR3rI1tLGydej?=
 =?us-ascii?Q?c5u6dVxMDptXkCu2/InMBcxHm6wA6whYd134muAUcs5fTr2iewC/87bsSJME?=
 =?us-ascii?Q?DoHlO2nFJkMNz1/r8QvhbazW9apq7GwyRSsw24B5mWBmES6sVHqwRMGBBOde?=
 =?us-ascii?Q?AwDeD/jQfPMOwEq1WsACGAHF/O2imNjncEU3oIbrSct/jqZ9GLW+zm2MkK8U?=
 =?us-ascii?Q?/WV+4QlIFCS8eGmCkt4ZudWMsja0rmhSoTjG4NbIy8piVImFI5TWbmf+dhIk?=
 =?us-ascii?Q?3/KMs+hYJbHQLsma4W/zfD1YXc+4ilgKy5PpN7Pc9uW67ue/echuzVeZRlAX?=
 =?us-ascii?Q?Qh7Jdn+XlVpdbJL6zsRrYAjR60mjw9lp14gCoYT1Fg6Zuf2JYWWw/lZO7PLr?=
 =?us-ascii?Q?mtu1+2rmdsT7HMgk6Xgt3it/xGF2ZCqTYJb0NOcIiesrkkxy2XFrly/ITBgL?=
 =?us-ascii?Q?s6Sp/EqMKfytvzPK+11fOvYMnRWXUvMzsUIgcZki+IjGXTovXLy4PnduAguq?=
 =?us-ascii?Q?QCvZvckdQDvWgDD5tEvqsMQqizGppsp0EON1LPHlVlxUppXDCbz89SAmMf3y?=
 =?us-ascii?Q?bVv9tK3P2sdnk8Uk3mvi59dS9X6pLgqa8DxH/1bcVuT40oQHySe4HhL3zdRe?=
 =?us-ascii?Q?Z8Hu9fTsOE6Xju2Hp86IgR7M7Gyo0d1cNHWB+zSAvahgYr8HJs0JD3Hl8jI2?=
 =?us-ascii?Q?iJNcud8L5jMpLqMyTfC0rCihwxmk2JbEwclrX69LEGg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: c00d89e8-9b9c-4052-f199-08d89b65e325
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2020 10:41:57.6882
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qwrhhnQyEsO/li+X5xX0d/WUURndXjs0Htae2vg27exKAxV+T7Z9V5h5fKOUJGuG1QmfOb4y63EcESx9i+oe/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3221
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 07, 2020 at 17:58PM, Rob Herring wrote:
> > +        properties:
> > +          regulator-mode:
> > +            maxItems: 1
> > +            description: Defined in include/dt-bindings/regulator/dlg,=
da9121-
> regulator.h
>=20
> 'regulator-mode' is defined as a property of a
> 'regulator-state-(standby|mem|disk)' child node. I don't see how you
> would use this with 'regulator-initial-mode' either.
>=20
> > +
> > +          regulator-initial-mode:
> > +            maxItems: 1
>=20
> 'maxItems' applies to arrays and this is not an array. What you should
> have is constraints on the values:
>=20
> enum: [ 0, 1, 2, 3 ]

OK, I see better now - would this be the valid way to scope them both?

        properties:
          regulator-state-(standby|mem|disk):
          type: object

            properties:
              regulator-mode:
              enum: [ 0, 1, 2, 3 ]
              description: Defined in include/dt-bindings/regulator/dlg,da9=
121-regulator.h

          regulator-initial-mode:
            enum: [ 0, 1, 2, 3 ]
            description: Defined in include/dt-bindings/regulator/dlg,da912=
1-regulator.h

I couldn't find a precedent in regulator yaml, and it's far removed enough =
from what
I see in the abstract JSON-schema documentation to make relating them trick=
y, even
if I had sufficient familiarity with the terminology to believe I'd properl=
y understood that!

Perhaps I'd be better off abandoning this attempt, and just having the regu=
lator
description mention these properties/file, like the texts for act8865 and m=
ax77802 do?