Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Dec 2020 11:15:00 +0200
From:   Eli Cohen <elic@nvidia.com>
To:     Jason Wang <jasowang@redhat.com>
CC:     <mst@redhat.com>, <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <lulu@redhat.com>,
        <elic@nvidia.com>
Subject: Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ
 index
Message-ID: <20201208091500.GA17763@mtl-vdi-166.wap.labs.mlnx>
References: <20201206105719.123753-1-elic@nvidia.com>
 <dd7cde10-2e75-1bd3-68ad-f4988274b37d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <dd7cde10-2e75-1bd3-68ad-f4988274b37d@redhat.com>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
Precedence: bulk

On Mon, Dec 07, 2020 at 10:51:44AM +0800, Jason Wang wrote:
>=20
> On 2020/12/6 =E4=B8=8B=E5=8D=886:57, Eli Cohen wrote:
> > Make sure to put write memory barrier after updating CQ consumer index
> > so the hardware knows that there are available CQE slots in the queue.
> >=20
> > Failure to do this can cause the update of the RX doorbell record to ge=
t
> > updated before the CQ consumer index resulting in CQ overrun.
> >=20
> > Change-Id: Ib0ae4c118cce524c9f492b32569179f3c1f04cc1

Michael, I left this gerrit ID by mistake. Can you remove it before
merging?

> > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 dev=
ices")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >=20
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/=
mlx5_vnet.c
> > index 1f4089c6f9d7..295f46eea2a5 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -478,6 +478,11 @@ static int mlx5_vdpa_poll_one(struct mlx5_vdpa_cq =
*vcq)
> >   static void mlx5_vdpa_handle_completions(struct mlx5_vdpa_virtqueue *=
mvq, int num)
> >   {
> >   	mlx5_cq_set_ci(&mvq->cq.mcq);
> > +
> > +	/* make sure CQ cosumer update is visible to the hardware before upda=
ting
> > +	 * RX doorbell record.
> > +	 */
> > +	wmb();
> >   	rx_post(&mvq->vqqp, num);
> >   	if (mvq->event_cb.callback)
> >   		mvq->event_cb.callback(mvq->event_cb.private);
>=20
>=20
> Acked-by: Jason Wang <jasowang@redhat.com>
>=20
>=20