Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3453834pxu; Tue, 8 Dec 2020 12:27:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzINaxPQV7wf06OmUQ3BNbFc+mpsJYIBthMAzkc3DhDPaqUZHfZMVmmxTBv8oyYqFSG2pUv X-Received: by 2002:a05:6402:1ad1:: with SMTP id ba17mr25711057edb.51.1607459279637; Tue, 08 Dec 2020 12:27:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607459279; cv=none; d=google.com; s=arc-20160816; b=s6FIgd6l94CpdYBN6krEvEN2RKvnnsT02M3xB+0ijw+OOuk2Oo6ehVAPwBg3FPZ+6W XkqvvAnqGibvfwn5CsHa8tHe/RAYeZmM9F4TzVwqBfn1CfVI+Z5D/s85CmZUesvbeqb9 L2GC1K18QI37upRWe1JLqD3Hv4440MHLpDgNeiueHvJT4dBl/KOWHtaxGIFtSENFG4KH Uh2/5sNqN0tuVgbr/EuEddyKY+x3S4cHSZ63BKv2A2cXlcksp8MeApnKBahkCpL6oMBL XDvjRVezvhLg1TIhsdKSI3pktRX9bM0o/n0SY54kzzZw4s+z3Px4/YadNk6tLcguH/pR GtZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=lrlskdOog5CVWGbF7/Thw8KLxYH0cddVeBHDzBpwphM=; b=pjL/fcEA1OTQKAxDiUVN389RqmDuZVhn0Ltzug9QqnpxyKdUOjXQG+AU2SS53tJuDj QeQNlJMAHoYY8O11B3ChaZSCKvj3S7d0Bn+ARRWBGohKG6J5O39YAtNdrUV4fKvmOWi8 vzzmcnXfhCHr1PN4nnWE8TEksadgCgoK3xLBxYrAVtUafpv1F5Jkajcm0g3u/5nTAsHa zATwOiy1L+0vLZqrOEuAPMvd9N+1T5V+fhg+1v8keFfsx4aZucbm4MJYBEHqEp7CDs3n kPQbp7uhBPnxJV7CRbw8g+p8tW+u3notfqO9KJIrChPzyVltLgsWkeDn/CQGs+NjMsvM bxgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 91si13429746edy.541.2020.12.08.12.27.37; Tue, 08 Dec 2020 12:27:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730552AbgLHRLm (ORCPT + 99 others); Tue, 8 Dec 2020 12:11:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:51746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730253AbgLHRLm (ORCPT ); Tue, 8 Dec 2020 12:11:42 -0500 From: Mark Brown Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Adam Ward , Support Opensource , Dan Carpenter Cc: Liam Girdwood , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH] regulator: da9121: Potential Oops in da9121_assign_chip_model() Message-Id: <160744745469.29972.2193088415551214848.b4-ty@kernel.org> Date: Tue, 08 Dec 2020 17:10:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2020 20:55:44 +0300, Dan Carpenter wrote: > There is a missing "return ret;" on this error path so we call > "da9121_check_device_type(i2c, chip);" which will end up dereferencing > "chip->regmap" and lead to an Oops. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: da9121: Potential Oops in da9121_assign_chip_model() commit: 8db06423e079b1f6c0657e5bebda0006acf75c3c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark