Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1607455638-4436-1-git-send-email-jrdr.linux@gmail.com> <875z5ccc0h.fsf@igel.home>
In-Reply-To: <875z5ccc0h.fsf@igel.home>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Wed, 9 Dec 2020 01:28:44 +0530
Message-ID: <CAFqt6zbp56nOfnLvuieMMtpEi7TXuB67bGS_Y=offyiROc=etg@mail.gmail.com>
Subject: Re: [PATCH] riscv: Fixed kernel test robot warning
To:     Andreas Schwab <schwab@linux-m68k.org>
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, guoren@linux.alibaba.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Dez 09 2020, Souptick Joarder wrote:
>
> > Kernel test robot throws below warning -
> >
> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
> > for 'asm_offsets' [-Wmissing-prototypes]
> >       14 | void asm_offsets(void)
> >          |      ^~~~~~~~~~~
> >
> > This patch should fixed it.
>
> Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will
work straight forward ?
I don't know much about this area of code.

>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."