Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3470947pxu;
        Tue, 8 Dec 2020 12:59:41 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwi1pJsjDt1rGafjWQsYDxETbiqN+wGm76ooD2i/4l+VxhPDmjabhQ2Cg1ZSATDzdNr95px
X-Received: by 2002:a17:906:9452:: with SMTP id z18mr25109527ejx.389.1607461181371;
        Tue, 08 Dec 2020 12:59:41 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1607461181; cv=none;
        d=google.com; s=arc-20160816;
        b=jU2QKPt6hYrrXnD5U8V88Fn7he3Mz3h4/tt7whE8+UjpuuVn9nuqfRFRPe5ApBR/6l
         oFV1mNbenVJuLqdeqUI/SYJQVVHY19XLv/L3bcc+2acA/C0kxc9uucLmND9ziIp2o1zj
         u2Eblup1nygeNsxaOTqjTQZz9PK1SOfW1C2HO7x2srodYyV7NA5usDjYQ4gAIuIOXLvI
         e60s5SoDqZrquUVf6GG0i3/3mDrmfNy5qfu4M3qYa3YkjnERLtSGCwydD1ITl2ONRRUd
         FzebHwPntxlNdLuUFDUUdrUiRJ1hI/GpC0N/xxWX6jn3ORH6pdO1e15Wdnj/AgRWcBe4
         nSUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=V/0+9h7ehwpCJcCPaTuvyhF/G9hja/cZk0UPNoDHO74=;
        b=QlkxKsMf69IsrI1SlzeMqa3/nCOmqLAZqHvQf8PrADv8qXzr/G16sO67ro7p+JHoBR
         Ty5MiKEK1CFGdzomi2tYn6JbWFuatiIDXWM/MgpD/mE5B4aNuDNEMnfTImmjPE4nh5kR
         76j3s3UTe+hpVZtih8zh8kvKbyNIc9RBvrvGi0MxT66vnrKFxVhPlqmVTies1fV0iKug
         iNF3gt5KBJliyHlrHW/qw1iLIbvTHe0V7Taz3lKRI2462iEoklbcLai8U5YUD3ti2lzO
         A+5zqwUWI5JLuBvKuJre1TXf/2ztE5HGDFtQefrXm76lTmDGfFFoMXpPlUMzH57Iu10K
         XZyQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=S0ie0J1A;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z6si8459073ejw.244.2020.12.08.12.59.18;
        Tue, 08 Dec 2020 12:59:41 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=S0ie0J1A;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727998AbgLHU1a (ORCPT <rfc822;wangyang4221683@gmail.com>
        + 99 others); Tue, 8 Dec 2020 15:27:30 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:11790 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726703AbgLHU11 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Dec 2020 15:27:27 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fcfe1860001>; Tue, 08 Dec 2020 12:26:46 -0800
Received: from [10.2.90.244] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 8 Dec
 2020 20:26:43 +0000
Subject: Re: [PATCH v3 10/13] media: v4l2-fwnode: Update
 V4L2_FWNODE_CSI2_MAX_DATA_LANES to 8
To:     Sakari Ailus <sakari.ailus@iki.fi>,
        Hans Verkuil <hverkuil@xs4all.nl>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <robh+dt@kernel.org>, <bparrot@ti.com>, <mchehab@kernel.org>,
        <linux-media@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <1607022002-26575-1-git-send-email-skomatineni@nvidia.com>
 <1607022002-26575-11-git-send-email-skomatineni@nvidia.com>
 <845dfd4a-fa11-625c-78a3-cc8adc68bfc7@xs4all.nl>
 <20201208195949.GB1167@valkosipuli.retiisi.org.uk>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <23de1994-0a3e-179b-2c2f-b41917d02585@nvidia.com>
Date:   Tue, 8 Dec 2020 12:27:22 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201208195949.GB1167@valkosipuli.retiisi.org.uk>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1607459206; bh=V/0+9h7ehwpCJcCPaTuvyhF/G9hja/cZk0UPNoDHO74=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:
         Content-Language:X-Originating-IP:X-ClientProxiedBy;
        b=S0ie0J1A5wC4XOAnEIdC/0Wl9YyUACghu0oMAax8zmeSgIDXjz049Fe24Bfch1hNF
         orRW/tsyQvlYk0IzXdsuQRtEWLwCrwyrNc/8MiCjcuomKAC0O+RfQZ/vHvvrswkM8n
         r2dngjrq9/oRiPcWa/maCNq6AFLwiVI9ImxSITsX75TYYuC95rw0PKjuWDF1OI9gIx
         Rri4K+0EqF2oFfCkBp4Bzv+TZmLagA8jZ9b2kuCcMIB5u6kXT+JD53ApZew5T5m98A
         ov3WjKl0tXYJVT/u4koi74kO8Qyzt8qRl3MagBR12ga5Fjyh3qP44PRoURp9pkTMWM
         5PmCqZt6t+n+A==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/20 11:59 AM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Dec 07, 2020 at 11:47:38AM +0100, Hans Verkuil wrote:
>> On 03/12/2020 19:59, Sowjanya Komatineni wrote:
>>> Some CSI2 receivers support 8 data lanes.
>>>
>>> So, this patch updates CSI2 maximum data lanes to be 8.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>>   drivers/media/platform/ti-vpe/cal-camerarx.c | 2 +-
>>>   include/media/v4l2-fwnode.h                  | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/ti-vpe/cal-camerarx.c b/drivers/media/platform/ti-vpe/cal-camerarx.c
>>> index 806cbf1..47e2143 100644
>>> --- a/drivers/media/platform/ti-vpe/cal-camerarx.c
>>> +++ b/drivers/media/platform/ti-vpe/cal-camerarx.c
>>> @@ -534,7 +534,7 @@ static int cal_camerarx_parse_dt(struct cal_camerarx *phy)
>>>   {
>>>   	struct v4l2_fwnode_endpoint *endpoint = &phy->endpoint;
>>>   	struct device_node *ep_node;
>>> -	char data_lanes[V4L2_FWNODE_CSI2_MAX_DATA_LANES * 2];
>>> +	char data_lanes[V4L2_FWNODE_CSI2_MAX_DATA_LANES];
>>>   	unsigned int i;
>>>   	int ret;
>>>   
>> I'm not so sure about this change: it relies on the implicit knowledge that
>> this cal driver can handle only 4 lanes max, so that doubling
>> V4L2_FWNODE_CSI2_MAX_DATA_LANES is the same as the old 'V4L2_FWNODE_CSI2_MAX_DATA_LANES * 2'.
>>
>> I think we should either keep the existing code (which means data_lanes
>> is now larger than needed, so stack usage increases by 8 bytes), or perhaps
>> create a new define for this driver like CAL_MAX_DATA_LANES and use that.
>>
>> In my opinion the original code should just be kept, but I've CC-ed Laurent
>> on this to hear what he thinks.
> I further looked at the code there and it does *depend* on a particular
> value of V4L2_FWNODE_CSI2_MAX_DATA_LANES. That needs to be fixed. This part
> can (or should) be dropped from the patch though.
>
Thanks Sakari and Hans.

OK. Will drop updating cal-camerarx.c from this patch in next version.