Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbWHaWoy (ORCPT ); Thu, 31 Aug 2006 18:44:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932471AbWHaWoy (ORCPT ); Thu, 31 Aug 2006 18:44:54 -0400 Received: from xenotime.net ([66.160.160.81]:23209 "HELO xenotime.net") by vger.kernel.org with SMTP id S932469AbWHaWox (ORCPT ); Thu, 31 Aug 2006 18:44:53 -0400 Date: Thu, 31 Aug 2006 15:48:19 -0700 From: "Randy.Dunlap" To: Pavel Machek Cc: Andrew Morton , "Rafael J. Wysocki" , kernel list Subject: Re: prevent swsusp with PAE Message-Id: <20060831154819.259c9ce2.rdunlap@xenotime.net> In-Reply-To: <20060831223521.GB31125@elf.ucw.cz> References: <20060831135336.GL3923@elf.ucw.cz> <20060831104304.e3514401.akpm@osdl.org> <20060831223521.GB31125@elf.ucw.cz> Organization: YPO4 X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 62 On Fri, 1 Sep 2006 00:35:21 +0200 Pavel Machek wrote: > Hi! > > > Pavel Machek wrote: > > > > > If HIGHMEM64G and swsusp are used at the same time, nasty random > > > crashes happen during resume. Cause is known; prevent that > > > combination. > > > > > > I guess I'd like to see this one in 2.6.18... > > > > > > Signed-off-by: Pavel Machek > > > > > > --- > > > commit acb3b411ec93f827b25b8481d53670c5c9195d89 > > > tree f52cd5518e34af16fe5ae28064717bcc95929f28 > > > parent cd03e183c58e6e7073e054a7fe335cf50c61fe2f > > > author Thu, 31 Aug 2006 15:52:34 +0200 > > > committer Thu, 31 Aug 2006 15:52:34 +0200 > > > > > > include/asm-i386/suspend.h | 8 ++++++++ > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > > > diff --git a/include/asm-i386/suspend.h b/include/asm-i386/suspend.h > > > index 08be1e5..01cd812 100644 > > > --- a/include/asm-i386/suspend.h > > > +++ b/include/asm-i386/suspend.h > > > @@ -16,6 +16,15 @@ arch_prepare_suspend(void) > > > printk(KERN_ERR "PSE is required for swsusp.\n"); > > > return -EPERM; > > > } > > > + > > > +#ifdef CONFIG_X86_PAE > > > + printk(KERN_ERR "swsusp is incompatible with PAE.\n"); > > > + /* This is actually instance of the same problem. We need > > > + identity mapping self-contained in swsusp_pg_dir, and PAE > > > + prevents that. Solution could be copied from x86_64. */ > > > + return -EPERM; > > > +#endif > > > + > > > return 0; > > > } > > > > Why not do this in Kconfig?? > > Well, Kconfig does not provide natural place for comments, and > disappearing config option is sure to confuse people. But of course I > can do it. Documentation/kbuild/kconfig-language.txt includes a "comment" keyword. USB-storage uses it to suggest that SCSI + SCSI disk support need to be enabled for usb-storage. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/