Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Punit Agrawal <punitagrawal@gmail.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Wei Huang <wei.huang2@amd.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        "the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: [RFC PATCH 0/4] Add processor to the ignore PSD override list
References: <20201125144847.3920-1-punitagrawal@gmail.com>
        <87zh2tp4x2.fsf@stealth>
        <CAJZ5v0gXSN+JcakF6jwnUYgej=LRyYc_jCff07Nx=nGO1a3mfw@mail.gmail.com>
Date:   Wed, 09 Dec 2020 08:25:07 +0900
In-Reply-To: <CAJZ5v0gXSN+JcakF6jwnUYgej=LRyYc_jCff07Nx=nGO1a3mfw@mail.gmail.com>
        (Rafael J. Wysocki's message of "Mon, 7 Dec 2020 14:55:17 +0100")
Message-ID: <87360fq3sc.fsf@stealth>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Rafael,

"Rafael J. Wysocki" <rafael@kernel.org> writes:

> On Fri, Dec 4, 2020 at 11:45 PM Punit Agrawal <punitagrawal@gmail.com> wrote:
>>
>> Hi Rafael,
>>
>> Punit Agrawal <punitagrawal@gmail.com> writes:
>>
>> > Hi,
>> >
>> > While looking into Giovanni's patches to enable frequency invariance
>> > on AMD systems[0], I noticed an issue with initialising frequency
>> > domain information on a recent AMD APU.
>> >
>> > Patch 1 refactors the test to ignore firmware provided frequency
>> > domain into a separate function.
>> >
>> > Patch 2 adds said APU (Family: 0x17, Model: 0x60, Stepping: 0x01) to
>> > the list of CPUs for which the PSD override is ignored. I am not quite
>> > happy with having to special case a particular CPU but also couldn't
>> > find any documentation to help identify the CPUs that don't need the
>> > override.
>>
>> Are you be OK to pick the first two patches if there are no issues?
>
> Please send them as non-RFC and change the name of override_acpi_psd()
> to indicate that it is AMD-specific.

Ack - I will incorporate your comments in the next version (once the
ongoing discussion finishes).

Thanks.