Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3582701pxu; Tue, 8 Dec 2020 16:21:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQ4PCxz0V/YRWG9n3aRIpR3EAJIL/Qcv8jShYbj8TwxcRttui6Cmhl+ZVdG+0yGDdlNHHm X-Received: by 2002:a17:906:2b95:: with SMTP id m21mr236494ejg.134.1607473308606; Tue, 08 Dec 2020 16:21:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607473308; cv=none; d=google.com; s=arc-20160816; b=t+5FxFdOYEi+S5ox6Kx9OoLeVtttUq3PXnD/oqg5D0wCNRGvLMcQcS4Z6VO2OoDssB m/1pTQNx3U0/r0ZqRs16Pz4ghb1qsKDX5f2hurU7Nfjs9pw5QknAf4Y0WkvwihzIjikW G2SwZl8j7GSoDmPk3KAsimlU24PJAcadz34ZBYAIxIN6Fve9+fggKvFy/rwBDsb2dGW7 5o/hIvR7SgJwLsVJBARTJo2t+YA9Xhn0ZlzDEgYuSriHdFwyNZapXV8iP4oDUOeVy/FP 94rT8CP9GO+GuiHOfwJ+MAu7ziP8jQSfxAxpmNlw79plAoeF+Jxo4npBwKCm9S2z3lW/ tQiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=gYcSt6hLNWdlz+SFeaxa+rSGgb8sCpmCaAlmVXOpsJA=; b=Y0nyhlF83wuBL1JPbPlPD1z48CLCvpPArfA92x/FHuNavEFyDBzgzMsjDrunRQ4DTH byvjZ3zPNb5hJPOt3srzeKBDnUxfw92aAHsZ1b7XMJgjSBSNyz2Aqq3ugg94BgtGbYFz LlwpoPrYEUQLnbK0cxw/QwL4eMf49NyG9qSTdHzZBS7iJQV/J6gmyfTt+Y/7X7bhE32Y jmfq6UxibCBRy90hhROqTtvUlHTiYvthvz7f7k9/S3PbX8IiYScb2/X47NHvl1GHdm/q qTUP+WZ/9brRTZGuG+09v0B4j1CGyuobdKi3VCaM/gpI63/1MHAIhbazZJ/8N7bQK+dq k5yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si27347ejf.612.2020.12.08.16.21.26; Tue, 08 Dec 2020 16:21:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730863AbgLIARd (ORCPT + 99 others); Tue, 8 Dec 2020 19:17:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730236AbgLIARd (ORCPT ); Tue, 8 Dec 2020 19:17:33 -0500 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3821FC0613D6; Tue, 8 Dec 2020 16:16:52 -0800 (PST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 6486E4D249B43; Tue, 8 Dec 2020 16:16:51 -0800 (PST) Date: Tue, 08 Dec 2020 16:16:50 -0800 (PST) Message-Id: <20201208.161650.1190066192708878176.davem@davemloft.net> To: zhangchangzhong@huawei.com Cc: kuba@kernel.org, michal.simek@xilinx.com, esben@geanix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe() From: David Miller In-Reply-To: <1607392422-20372-1-git-send-email-zhangchangzhong@huawei.com> References: <1607392422-20372-1-git-send-email-zhangchangzhong@huawei.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Tue, 08 Dec 2020 16:16:51 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Changzhong Date: Tue, 8 Dec 2020 09:53:42 +0800 > platform_get_resource() may fail and in this case a NULL dereference > will occur. > > Fix it to use devm_platform_ioremap_resource() instead of calling > platform_get_resource() and devm_ioremap(). > > This is detected by Coccinelle semantic patch. > > @@ > expression pdev, res, n, t, e, e1, e2; > @@ > > res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n); > + if (!res) > + return -EINVAL; > ... when != res == NULL > e = devm_ioremap(e1, res->start, e2); > > Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms") > Signed-off-by: Zhang Changzhong Applied, thanks.