Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ubxPVOlpTzJOiSklyJd8zHcDjDbKmp3NHxSaCQpj0oPheFX9VtW51oZPD499nM8xTJjaGMrfKq
 eP/CNgoPXDiA==
IronPort-SDR: KYvZoxPyRwlOOZ8QXHwidHpQuTb3rrBasrE0/EqcVwfvwaUqz8abgVtpeVBqsxxAtYXoAXm80E
 fIt/YadmclQA==
From:   "Sia, Jee Heng" <jee.heng.sia@intel.com>
To:     Rob Herring <robh@kernel.org>
CC:     "vkoul@kernel.org" <vkoul@kernel.org>,
        "Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v5 10/16] dt-binding: dma: dw-axi-dmac: Add support for
 Intel KeemBay AxiDMA
Thread-Topic: [PATCH v5 10/16] dt-binding: dma: dw-axi-dmac: Add support for
 Intel KeemBay AxiDMA
Thread-Index: AQHWx2hI8Yw8RptSb0yigarW3N6LYanuDFTg
Date:   Wed, 9 Dec 2020 01:53:00 +0000
Message-ID: <CO1PR11MB5026959BF7099588C163DB5DDACC0@CO1PR11MB5026.namprd11.prod.outlook.com>
References: <20201123023452.7894-1-jee.heng.sia@intel.com>
 <20201123023452.7894-11-jee.heng.sia@intel.com>
 <20201130222916.GA3146362@robh.at.kernel.org>
In-Reply-To: <20201130222916.GA3146362@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b67ee28-9704-4e2a-1dbf-08d89be528c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 01:53:00.5358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: orI/irgt9EkivIwUbzFTIVghPX12EBHI0nbtTBsHY9kVmTtdS/Au/wTTqN5S4TXJrDeDZ1fuGtBGwX0y9drKDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1295
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 01 December 2020 6:29 AM
> To: Sia, Jee Heng <jee.heng.sia@intel.com>
> Cc: vkoul@kernel.org; Eugeniy.Paltsev@synopsys.com;
> andriy.shevchenko@linux.intel.com; dmaengine@vger.kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v5 10/16] dt-binding: dma: dw-axi-dmac: Add
> support for Intel KeemBay AxiDMA
>=20
> On Mon, Nov 23, 2020 at 10:34:46AM +0800, Sia Jee Heng wrote:
> > Add support for Intel KeemBay AxiDMA to the dw-axi-dmac Schemas
> DT
> > binding.
> >
> > Signed-off-by: Sia Jee Heng <jee.heng.sia@intel.com>
> > ---
> >  .../bindings/dma/snps,dw-axi-dmac.yaml        | 27
> +++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 6c2e8e612af5..9e3ca9083814 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-
> dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-
> dmac.yaml
> > @@ -8,6 +8,7 @@ title: Synopsys DesignWare AXI DMA Controller
> >
> >  maintainers:
> >    - Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com
>=20
> Also, for the first patch, missing a '>' on the end.
[>>] Got it. Thanks for the catch.
>=20
> > +  - Jee Heng Sia <jee.heng.sia@intel.com>
> >
> >  description: |
> >   Synopsys DesignWare AXI DMA Controller DT Binding @@ -16,14
> +17,18
> > @@ properties:
> >    compatible:
> >      enum:
> >        - snps,axi-dma-1.01a
> > +      - intel,kmb-axi-dma
> >
> >    reg:
> > +    minItems: 1
> >      items:
> >        - description: Address range of the DMAC registers
> > +      - description: Address range of the DMAC APB registers
>=20
> Nevermind for my 'reg' comment on the first patch.
[>>] OK.
>=20
> >
> >    reg-names:
> >      items:
> >        - const: axidma_ctrl_regs
> > +      - const: axidma_apb_regs
> >
> >    interrupts:
> >      maxItems: 1
> > @@ -124,3 +129,25 @@ examples:
> >           snps,priority =3D <0 1 2 3>;
> >           snps,axi-max-burst-len =3D <16>;
> >       };
> > +
> > +  - |
>=20
> For what's just a new compatible and extra reg field, I don't think we
> need another example.
[>>] I would suggest to provide the below example if you don't see any harm=
ful.
>=20
[>>] The reason is because those compatible and new reg help customer under=
stand the setup
> > +     #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +     #include <dt-bindings/interrupt-controller/irq.h>
> > +     /* example with intel,kmb-axi-dma */
> > +     #define KEEM_BAY_PSS_AXI_DMA
> > +     #define KEEM_BAY_PSS_APB_AXI_DMA
> > +     axi_dma: dma@28000000 {
> > +         compatible =3D "intel,kmb-axi-dma";
> > +         reg =3D <0x28000000 0x1000>, <0x20250000 0x24>;
> > +         reg-names =3D "axidma_ctrl_regs", "axidma_apb_regs";
> > +         interrupts =3D <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> > +         clock-names =3D "core-clk", "cfgr-clk";
> > +         clocks =3D <&scmi_clk KEEM_BAY_PSS_AXI_DMA>, <&scmi_clk
> KEEM_BAY_PSS_APB_AXI_DMA>;
> > +         #dma-cells =3D <1>;
> > +         dma-channels =3D <8>;
> > +         snps,dma-masters =3D <1>;
> > +         snps,data-width =3D <4>;
> > +         snps,priority =3D <0 0 0 0 0 0 0 0>;
> > +         snps,block-size =3D <1024 1024 1024 1024 1024 1024 1024
> 1024>;
> > +         snps,axi-max-burst-len =3D <16>;
> > +     };
> > --
> > 2.18.0
> >