Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Zou Wei <zou_wei@huawei.com>
CC:     "pawell@cadence.com" <pawell@cadence.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static
 keyword
Thread-Topic: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static
 keyword
Thread-Index: AQHWzVyuwhB38e6st02GMKSdkSAp5anuDnKA
Date:   Wed, 9 Dec 2020 02:40:28 +0000
Message-ID: <20201209023958.GB995@b29397-desktop>
References: <1607430649-116383-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1607430649-116383-1-git-send-email-zou_wei@huawei.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.9.4 (2018-02-28)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B8344A71C7110447AC89B34304F6E489@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b07f78f2-f8ff-4176-c2d3-08d89bebca4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 02:40:28.5078
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q9EAPnaZg+QGrg4lmRUXt26Z98QZwsOVztBP2RYmstesBwm577bUb1vU7mCH3b+y0NI495wrsdQ3V3TmjnLFHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2758
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-12-08 20:30:49, Zou Wei wrote:
> Fix the following sparse warning:
>=20
> drivers/usb/cdns3/cdnsp-gadget.c:1546:29: warning: symbol 'cdnsp_gadget_o=
ps' was not declared. Should it be static?
>=20
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-g=
adget.c
> index 9716273..c7c5d0a 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1543,7 +1543,7 @@ static int cdnsp_gadget_pullup(struct usb_gadget *g=
adget, int is_on)
>  	return 0;
>  }
> =20
> -const struct usb_gadget_ops cdnsp_gadget_ops =3D {
> +static const struct usb_gadget_ops cdnsp_gadget_ops =3D {
>  	.get_frame		=3D cdnsp_gadget_get_frame,
>  	.wakeup			=3D cdnsp_gadget_wakeup,
>  	.set_selfpowered	=3D cdnsp_gadget_set_selfpowered,
> --=20

Applied, thanks.

--=20

Thanks,
Peter Chen=