Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] erofs: avoiding using generic_block_bmap
To:     Gao Xiang <hsiangkao@redhat.com>,
        Huang Jianan <huangjianan@oppo.com>
CC:     <linux-erofs@lists.ozlabs.org>, <guoweichao@oppo.com>,
        <zhangshiming@oppo.com>, <linux-kernel@vger.kernel.org>
References: <20201208131108.7607-1-huangjianan@oppo.com>
 <c71fe6a9-06ba-3871-6e0b-104f58df1df7@oppo.com>
 <20201209024415.GA33948@xiangao.remote.csb>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <fd9d991d-c048-500f-ca52-f186c42974b1@huawei.com>
Date:   Wed, 9 Dec 2020 10:56:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20201209024415.GA33948@xiangao.remote.csb>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2020/12/9 10:44, Gao Xiang wrote:
> Hi Jianan and Chao,
> 
> On Wed, Dec 09, 2020 at 10:34:54AM +0800, Huang Jianan wrote:
>>
>> 在 2020/12/8 21:11, Huang Jianan 写道:
> 
> ...
> 
>>> -
>>>    static sector_t erofs_bmap(struct address_space *mapping, sector_t block)
>>>    {
>>>    	struct inode *inode = mapping->host;
>>> +	struct erofs_map_blocks map = {
>>> +		.m_la = blknr_to_addr(iblock),
>>
>> Sorry for my mistake, it should be:
>>
>> .m_la = blknr_to_addr(block),
>>
> 
> Sigh, since my ro_fsstress doesn't cover bmap interface... I mean do we need
> to add some testcase for this? (But it needs to be fixed anyway, plus this patch
> looks good to me....)
> 
> Hi Chao,
> could you kindly leave some free slot for this patch and
> 
> erofs: force inplace I/O under low memory scenario
> https://lore.kernel.org/r/20201208054600.16302-1-hsiangkao@aol.com

Will review soon. :)

Thanks,

> 
> Since I'd like to merge these all for 5.11-rc1 (so we could have more time to
> test until the next LTS version), since 5.10 is a LTS version, I tend to not
> introduce any big modification (so in the past months, "erofs: force inplace
> I/O under low memory scenario" never upstreamed at all.)
> 
> Thanks,
> Gao Xiang
> 
> 
> .
>