Message-ID: <44F78A67.1060007@student.ltu.se>
Date: Fri, 01 Sep 2006 03:18:31 +0200
From: Richard Knutsson <ricknu-0@student.ltu.se>
User-Agent: Mozilla Thunderbird 1.0.8-1.1.fc4 (X11/20060501)
MIME-Version: 1.0
To: Nathan Scott <nathans@sgi.com>
CC: akpm@osdl.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement
References: <44F77653.6000606@student.ltu.se> <20060901100745.P3186664@wobbly.melbourne.sgi.com>
In-Reply-To: <20060901100745.P3186664@wobbly.melbourne.sgi.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1104
Lines: 42

Nathan Scott wrote:

>On Fri, Sep 01, 2006 at 01:52:51AM +0200, Richard Knutsson wrote:
>  
>
>>From: Richard Knutsson <ricknu-0@student.ltu.se>
>>
>>Converting error-prone statement:
>>"if (var == B_FALSE)" into "if (!var)"
>>"if (var == B_TRUE)"  into "if (var)"
>>    
>>
>
>This is my preference too, rather than the local boolean usage which
>isn't used with any consistency... but:
>
>  
>
>>Compile-tested
>>    
>>
>
>Are you using XFS on your systems?  What is your strategy for getting this
>runtime tested going to be?  Or are you delegating that responsibility? :)
>  
>
Sorry, can't say that I do. So pretty please... ;)
Seriously, I can not find a state when this may fail (if not "if (var == 
TRUE)" happend to be correct for 'var' != 0 != 1, but that is just a bug 
waiting to happend).
But please correct me if I am wrong.

>cheers.
>  
>
cu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/