Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm
Subject: [PATCH v2 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()
Date:   Wed,  9 Dec 2020 14:24:24 +0800
Message-Id: <1607495069-10946-2-git-send-email-victor.liu@nxp.com>
In-Reply-To: <1607495069-10946-1-git-send-email-victor.liu@nxp.com>
References: <1607495069-10946-1-git-send-email-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0148.apcprd06.prod.outlook.com (2603:1096:1:1f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 06:32:52 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 791e4ddb-fc67-4224-9422-08d89c0c457c
X-MS-TrafficTypeDiagnostic: VI1PR04MB6144:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB6144E4885C286FB9678D657498CC0@VI1PR04MB6144.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KZFgGssoxvMYJwGnrUmeYGO/HtvlTK6lZyMzcJKp+yD50ZyUXZ0ZydPZW3WDuhnuyjug/0Ej2fXxvINO0yhdb8m+rW3T1esraWtjpkU+nGnueaWizWTkU0+a+wrnAQMDpjkP0O9LUT9MR7b5nKx964/lGLv6RCZ5bVV7MqXgkoqMRapYkUrMBOYqhkxfZyAq9racUGmz9Hjw7z4sWvjt/mOGvMPlLSHoCU3azXUZ3VII/LYkeRcWA6aFKI8Hh8U7NHoRh7XmM3vVxpQU3smuv5ZiZhyyCpiee+HDS5eitecCBeFC6WLmCMTy1nBZlo+sRGDtpEcWiIrwLE3eJBLdaludY541ozSGG5Ni1kRLPNE4DOX2XqkNQL3iuqZJV/B9
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB3983.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(2616005)(26005)(52116002)(5660300002)(186003)(16526019)(34490700003)(8936002)(8676002)(6486002)(6666004)(66476007)(2906002)(7416002)(956004)(36756003)(6512007)(508600001)(66946007)(4326008)(6506007)(86362001)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YTAyVGdhc1dVYUVKT05jVFY1YzhJMjRPSjN2allhTkNVZGluVEQ5QTY1UkJt?=
 =?utf-8?B?UE82cXdVQmt1WitFL0xNNS9RRnBCUW81SHowM1NlUWJqSTB1NXpsajdSZ0lx?=
 =?utf-8?B?cVFBR3hpT2M0blJDejR2OTBReFhrTDNVUW5pclZvNTRwVGtHcmErRzZRQ0JZ?=
 =?utf-8?B?VGpoWlVkYnBFdGQ5dVVDOGl4djdjWTBycjdVZElRV1RNaW9LMk0zUmoxZ042?=
 =?utf-8?B?VDgrNGw5MytNSjIrUU9MUlUyK1JTS3FramFWT2EyMFhGNzNZMUlXK0RFWFk1?=
 =?utf-8?B?WENUdlZuK3pRamtBOUhPbjZWZzgyd3FKelZUb2VHODJoSm9tOW40T0F5bUs5?=
 =?utf-8?B?M21tTGFNWitlYkRkYjJVRzEyaDZrUjZzSHBqaWVpV0dJdGNGVUNUY0h6TzlB?=
 =?utf-8?B?bG50dXkyNkgrU2RhemdmZXV6Nm42M04zam5ITHZOaWpUZ3Zvc1ZXekVFOEtj?=
 =?utf-8?B?NzBNTjNxdWg2V1FlMlREZnc1ME1qNlI3eFczemdhWmhzZWtYU3hreVJlVXBY?=
 =?utf-8?B?UHo4UDhuNGF2dFNocE1XQWxmNTk3eXpNM3YrVzFIRWRQcjc0b1hxTTBQOGdy?=
 =?utf-8?B?MXRIWXJqSjV6ZlVjemszeTY5NnNjQUwvZXlzZ3c1dHNtZDNJMVorWFdValdH?=
 =?utf-8?B?UEtvWEhtQXpyTWp0c0lVbzlwOWxhQUs3L0x3ZTNDdDlpVXJXWkFlZE1VQ245?=
 =?utf-8?B?cGxYeFJzYlZKcnVlVXpUSjgwYlpjdXJHK3BoWS9aYllmUzByNUE5cjNDWHk1?=
 =?utf-8?B?bEpLYk1VR25zSU5mcUlsR0tzdmU5N2s5NHBEYnlWUGoyWnFINitNTmlpN2dv?=
 =?utf-8?B?S0ZqV2RpQ1lzRUF3VnBDbEFhMWdRQWc5YloxMXZFQUxsUFJkbTk1ZkdscVNj?=
 =?utf-8?B?Q2tmZFJmV0tVRVM2bUx5Wk15NENzWE91NlZ0MkVmZHJ3S05DTi9hSWpHa0h2?=
 =?utf-8?B?K0VXRmJtZGV6c21DTDZzNkkxSEhjMy91YnVyVEpmak1IUkVuTEdHdjYvL3oz?=
 =?utf-8?B?aVZJb2Y2L01iYVIvWGxLanAyRVN4YnFWaGhOQkpQekxIcTJCaldWOWRSejdk?=
 =?utf-8?B?cmdZNEFWZ0ZaWFo0c2tTZW1UWEcwOEs4aFR4ZzRtbnpUalo3TjFFUnVVNDQ0?=
 =?utf-8?B?SzZqSHVvQ0lMRE9ONXoxSkRNU3lGNHAvNzRnMlNKazdRWnhQWmN4S2h5MnVV?=
 =?utf-8?B?R0oxSUtZQzBTTVNzSk9NNFdUS1FJZWtZVzJjSkdMbFlyV1kwcXNyL3I2N3R1?=
 =?utf-8?B?SGtkeHFkM0RRS1dPckYyYTExRW43OEwvSHEvZFg5SEgyRDIrbDZmNXdCUVh2?=
 =?utf-8?Q?SvAeUQESHl+GmkRak9ts4ZA+9V6Pd5gaxC?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 06:32:59.0499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-Network-Message-Id: 791e4ddb-fc67-4224-9422-08d89c0c457c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L8Rx8kTRN613DoWxiiy7aIadLWU+pf3rxCm3DD7sO0Kzrz3iVgM7zMuMqxGUU0/etJNZdsfzEY0QziJDnK2Qdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6144
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index 66b6740..be6bfc5 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.7.4