Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3866432pxu; Wed, 9 Dec 2020 02:37:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwckqOjw35Ei469P8OQXMts/nRNhhLyhK9TRLnS+75jmQQZdIUVNpcfQaVKWY7sC3eGA6eA X-Received: by 2002:aa7:d494:: with SMTP id b20mr1425382edr.330.1607510257228; Wed, 09 Dec 2020 02:37:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607510257; cv=none; d=google.com; s=arc-20160816; b=dE9fb3gqbT0Ep57Hentw/cHB8lRaUrpdiLj/ejDEigU6DSEQayfiW0GKhMccpZeZc/ TKPgjuQ1rIhA+00dxH8RkgJWc1LcCH1S+UcEjYUacpOIEZq20zjpeSM/ZR4+Gj/ij1QD XyHOK0fnJTwLGk2/sfmSNFrWogBzzSexMMRqrfA5J0xVg73XIhMOBKtxICVmb2lOcd/D kK1N5XtGXyiCpBq+FUod+/3l27ZyOqXZwUPpyTbQJHitqlhKpWW7gSAJdPv4uStb5kFd 5W+8KSSNHEAi9iTZvzjlHcg2wWqtpiQEkyUr6B9YqSlZdXNwF2LnAHTFQFlc+faxjO+k lDrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OksspaGjPuFf4DB6wu1ypZZhywmIYxJ9IAHMFgvOtwM=; b=xODoyBp/PgFLDRNiWjiMzHyr87fTO2iJcmBWnngMSo2ubHtsVoNwbw8rjEQA/bgdHo Anse5zXPZBqv8gvrtRDQvauoZDuzRqiksJHHNk1HLtq1v0AZd9GERMWD65v1hUPjhj8I YhEhyWTTApevEs/2CLMpnS/BdRuh9o4t5PZgdtYpgK8pnyz2Q8tUeZCuFWYBeB3sHGMO vqhRI5qOOIX+xiQaDdQTwPxaJzwDIHEYaGuqefZlUkiOT+7qTu8CS1jvQYaKbapQH2Hf Jjrf6y0EB25INvy2IChK9eUjwzGCxw6D8oauAzcS7Ts9A8e2dohekzDODkVPpxvxufM9 PJ1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=ljaGQawJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn1si640890edb.113.2020.12.09.02.37.14; Wed, 09 Dec 2020 02:37:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=ljaGQawJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729768AbgLIKbe (ORCPT + 99 others); Wed, 9 Dec 2020 05:31:34 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:51244 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgLIKbd (ORCPT ); Wed, 9 Dec 2020 05:31:33 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9ATao2128032; Wed, 9 Dec 2020 10:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=OksspaGjPuFf4DB6wu1ypZZhywmIYxJ9IAHMFgvOtwM=; b=ljaGQawJU7IpvhND5+dnVqHbkHhHHIOzPud6PGsmNBMT50t1MKtOQhQHxOuHgvO0t2Da n0VqYsXmXl4yjRNgypb229cj7nXISl8ILhx8pxws4fpf8kbSuO/4Wc//SFVp0ABsHWP0 uRZIxzqlK7ZAZBib0X/y37r6CFO83TYFVIrL+KDhoh28YwekQ+e8fmRnUTlbicmt5yBb OvRv7edncITmBmfViisASCBZRdlWXKxNVVViRtJrGi1wSYifmIJhGg0ZeeYGs+vpg/7+ ptolQK6K9IPjRJRw5w/Nhwpsnnsbouo0FEzGCkhN5D2AjH1Ih0+J7up4qnh6N7tDVBlO 7A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 357yqbyhs7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Dec 2020 10:30:44 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9AUhJO092612; Wed, 9 Dec 2020 10:30:43 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 358kyue1k2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Dec 2020 10:30:43 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B9AUY57010634; Wed, 9 Dec 2020 10:30:34 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Dec 2020 02:30:33 -0800 Date: Wed, 9 Dec 2020 13:30:26 +0300 From: Dan Carpenter To: Joe Perches Cc: "ksummit-discuss@lists.linuxfoundation.org" , Greg KH , LKML , Colin Ian King , Vlastimil Babka Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch Message-ID: <20201209103026.GF2767@kadam> References: <20201203093458.GA16543@unreal> <20201203104047.GD16543@unreal> <202012081619.6593C87D3@keescook> <13d04c4cc769ebd1dd58470f4d22ada5c9cd28e7.camel@perches.com> <20201209075849.GD2767@kadam> <42a599d0f5e4c677648b5e6de8083feb8723a558.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42a599d0f5e4c677648b5e6de8083feb8723a558.camel@perches.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090072 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090072 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2020 at 12:54:30AM -0800, Joe Perches wrote: > On Wed, 2020-12-09 at 10:58 +0300, Dan Carpenter wrote: > > On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote: > > > On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote: > > > > > > > If not "Adjusted-by", what about "Tweaked-by", "Helped-by", > > > > "Corrected-by"? > > > > > > Improved-by: / Enhanced-by: / Revisions-by: > > > > > > > I don't think we should give any credit for improvements or enhancements, > > only for fixes. > > Hey Dan. > > I do. If a patch isn't comprehensive and a reviewer notices some > missing coverage or algorithmic performance enhancement, I think that > should be noted. > > > Complaining about style is its own reward. > > > > I believe I've said multiple times that style changes shouldn't require > additional commentary added to a patch. > > I'm not making any suggestion to comment for style, only logic or defect > reduction/improvements as described above. How about we make the standard, "Would this fix be backported to stable?" > > > Having to redo a patch is already a huge headache. Normally, I already > > considered the reviewer's prefered style and decided I didn't like it. > > Example please. We both seem to prefer consistent style. > For example, if you have a signedness bugs: ret = frob(unsigned_long_size); - if (ret < unsigned_long_size) + if (ret < 0 || ret < unsigned_long_size) vs: + if (ret < (int)unsigned_long_size) goto whatever; To me, whoever fixes the bug gets to choose their prefered style but maybe some reviewers have strong feelings one way or the other. > > Then to make me redo the patch in an ugly style and say thank you on > > top of that??? Forget about it. > > Not a thing I've asked for. > > > Plus, as a reviewer I hate reviewing patches over and over. > > interdiff could be improved. > > > I've argued for years that we should have a Fixes-from: tag. The zero > > day bot is already encouraging people to add Reported-by tags for this > > and a lot of people do. > > It's still a question of what fixes means in any context. > > https://www.google.com/search?q=%27fixes-from%3A%27%20carpenter%20site%3Alore.kernel.org > gives: > It looks like there aren't many great matches for your search > No, I mean people add Reported-by tags for fixes to the original commit like in commit f026d8ca2904 ("igc: add support to eeprom, registers and link self-tests"). regards, dan carpenter