Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Dec 2020 14:09:21 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        netdev@vger.kernel.org
Subject: Re: [PATCH net v1] net: dsa: qca: ar9331: fix sleeping function
 called from invalid context bug
Message-ID: <20201209130920.hjjnfh2ioc33yd2y@pengutronix.de>
References: <20201204145751.13166-1-o.rempel@pengutronix.de>
 <8f44d5cb-fa99-b004-078e-078241f265a0@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8f44d5cb-fa99-b004-078e-078241f265a0@pengutronix.de>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Fri, Dec 04, 2020 at 04:00:35PM +0100, Marc Kleine-Budde wrote:
> On 12/4/20 3:57 PM, Oleksij Rempel wrote:
> [...]
> 
> 
> > +static void ar9331_sw_irq_bus_sync_unlock(struct irq_data *d)
> >  {
> >  	struct ar9331_sw_priv *priv = irq_data_get_irq_chip_data(d);
> >  	struct regmap *regmap = priv->regmap;
> >  	int ret;
> >  
> >  	ret = regmap_update_bits(regmap, AR9331_SW_REG_GINT_MASK,
> > -				 AR9331_SW_GINT_PHY_INT,
> > -				 AR9331_SW_GINT_PHY_INT);
> > +				 AR9331_SW_GINT_PHY_INT, priv->irq_mask);
> >  	if (ret)
> > -		dev_err(priv->dev, "could not unmask IRQ\n");
> > +		dev_err(priv->dev, "could not mask IRQ\n");
> 
> Technically this could be a mask or unmask operation. What about changing the
> error message to: "faild to change IRQ mask"?

OK, it make sense. I'll fix it.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |