Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4043032pxu; Wed, 9 Dec 2020 07:05:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhP7ct2U35v29aADwfmzCbRD06GALxyJaN38D4QIuKsZgLuyNSaK3mUGfWRQ0Tke00Hrml X-Received: by 2002:a05:6402:19b0:: with SMTP id o16mr2408770edz.270.1607526325835; Wed, 09 Dec 2020 07:05:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607526325; cv=none; d=google.com; s=arc-20160816; b=jWGb7/gvCT7yh/Ob/vFEvQNwYikAPlzFlNY+gGWyPp2juPFgDhPMm7HaEANgkq1xi3 9Rju5Tlv+ENE0+XMG4KQsGEskyBZHnRfz77wCcMi41KHhqeRko54JRQc9GSoFrfibwPQ LeIuCH7y9bxSuJLSgDAwvOoU0d8qoBCFRa7uPdfOod5ahpT0Ds9JYSer5FGQNpPzPHoj 2jwgV7Na5kSKIUFb+M422p6/5PuGamLgDEdBqCIvYAOFZjS2s98Ur0ojzqmWIyaj7Mr6 P8F3UKz/+ljrbqa3wpKcGieY9mANFJo/MWzpPCWkKS4BZoah/goE6YsWs799ixquberK 7Mlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Au4JwJB9lpsSHZoHNpEyScn57cY/3LNfmfAMZVumhYM=; b=Y5Nb9GPwlt79b6bT3708X0pqjoPCJDwjJuWnIVr2XbyHNFv5D0BWsQyAHuYHGzheJh csP61eJEWHFfXSayfn0qFrNphy7a7B8MhGZOFd7tvQleO2x0sbjj28xJgxT4Rx0D+0h9 /u8fkldGjDO5Wm/25/hgrON+5s90WoiYlF80RIcjOWCgONZBga8fJyWXWtllycNaV0TV mguI8cObx+6wxkpYvxDwifxewUPsWujeJHiL101K5jqwBMLbOPyMFrwMrpWDve+mCHGb rssX2JbeB9532EFulOrV6Nq+OK4BvY6av8g3oQFn5dc4gXzdRk9HTkIc+NUWhVnf2gf0 UwfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yadro.com header.s=mta-01 header.b=brbS8joU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yadro.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si1013017ejd.449.2020.12.09.07.04.59; Wed, 09 Dec 2020 07:05:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@yadro.com header.s=mta-01 header.b=brbS8joU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yadro.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732737AbgLIOAj (ORCPT + 99 others); Wed, 9 Dec 2020 09:00:39 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:54180 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728541AbgLIOAb (ORCPT ); Wed, 9 Dec 2020 09:00:31 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 84595412D0; Wed, 9 Dec 2020 13:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1607522385; x= 1609336786; bh=LtEwQr607pb2Yng6ZB5puQAfklphP2HMsQC9LGAQ5ak=; b=b rbS8joU0P2khd8vLyglphVBDGyjJuo2wlPtbQJx73NtWwUCcBVxuTQo37tca7vAQ YhdSsKcKu5apjiwZmv7HIcBqqfywOjiC0DN2aUtkKCrJYg2IIyDtZr5MFyF4Wnqv ahgOv0n/FZXd+81wbJwkZPM09t6lKBVbiUMA3MQZ8A= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OJXlTB2a5lsQ; Wed, 9 Dec 2020 16:59:45 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 498BE41203; Wed, 9 Dec 2020 16:59:43 +0300 (MSK) Received: from localhost.dev.yadro.com (10.199.0.125) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Wed, 9 Dec 2020 16:59:42 +0300 From: Ivan Mikhaylov To: "David S . Miller" , Jakub Kicinski , Rob Herring , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King CC: Ivan Mikhaylov , , , Subject: [PATCH 0/2] Add LED mode behavior/select properties and handle Date: Wed, 9 Dec 2020 17:04:59 +0300 Message-ID: <20201209140501.17415-1-i.mikhaylov@yadro.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.199.0.125] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In KSZ9131 PHY it is possible to control LEDs blink behavior via LED mode behavior and select registers. Add DTS properties plus handles of them inside micrel PHY driver. I've some concerns about passing raw register values into LED mode select and behavior. It can be passed via array like in microchip driver(Documentation/devicetree/bindings/net/microchip,lan78xx.txt). There is the problem in this particular driver - there is a lot of other PHYs and led mode behavior/select states may intersect, that's the reason why I did it this way. Is there any good ways to make it look more properly? Ivan Mikhaylov (2): net: phy: micrel: add LED control on KSZ9131 dt-bindings: net: phy: micrel: add LED mode behavior and select properties .../devicetree/bindings/net/micrel.txt | 7 ++ drivers/net/phy/micrel.c | 69 ++++++++++++++++++- 2 files changed, 75 insertions(+), 1 deletion(-) -- 2.21.1