Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Dec 2020 15:54:26 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Jim Cromie <jim.cromie@gmail.com>
Cc:     Jason Baron <jbaron@akamai.com>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] dyndbg: fix use before null check
Message-ID: <X9DlIkNg2mVf20Bo@kroah.com>
References: <20201123184334.1777186-1-jim.cromie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201123184334.1777186-1-jim.cromie@gmail.com>
Precedence: bulk

On Mon, Nov 23, 2020 at 11:43:34AM -0700, Jim Cromie wrote:
> commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")
> 
> Above commit copies a string before checking for null pointer, fix
> this, and add a pr_err.  Also trim comment, and add return val info.

The way you list the above commit is very odd, and hard to read and
understand.  How about something like:

	In commit a2d375eda771 ("dyndbg: refine export, rename to
	dynamic_debug_exec_queries()"), a string is copied before
	checking....


Also, when you say "also" in a patch, that is a HUGE flag that the
commit needs to be broken up into multiple patches.  Put the bugfix
first, and then fix up the comment later, if it is not being changed for
this fix.

Also:

> Fixes: a2d375eda771

You need the full information here, please write:
	Fixes: a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")


Can you fix all of that up and resend?

thanks,

greg k-h