Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mkshah=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5FE48C433C6
Subject: Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register
 write on trigger
To:     Doug Anderson <dianders@chromium.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Lina Iyer <ilina@codeaurora.org>,
        Srinivas Rao L <lsrao@codeaurora.org>,
        Stephen Boyd <swboyd@chromium.org>
References: <1606211610-15168-1-git-send-email-mkshah@codeaurora.org>
 <CAD=FV=Xk_1=eCvqLPPnYLrQWf1zVy+iEHs=DWEubb6n5ub3Wxw@mail.gmail.com>
 <CAD=FV=XafiNR+vZc2nM6JzhU7xPm9v3eeeR5SMhBM3k3mmsZDQ@mail.gmail.com>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <37d7a6e4-8773-6de2-8914-b39e656ed2f0@codeaurora.org>
Date:   Wed, 9 Dec 2020 16:34:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <CAD=FV=XafiNR+vZc2nM6JzhU7xPm9v3eeeR5SMhBM3k3mmsZDQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Precedence: bulk

Hi Doug,

On 12/4/2020 2:47 AM, Doug Anderson wrote:
> Hi,
>
> On Thu, Dec 3, 2020 at 1:15 PM Doug Anderson <dianders@chromium.org> wrote:
>> Hi,
>>
>> On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>>> From: Lina Iyer <ilina@codeaurora.org>
>>>
>>> When triggering a TCS to send its contents, reading back the trigger
>>> value may return an incorrect value. That is because, writing the
>>> trigger may raise an interrupt which could be handled immediately and
>>> the trigger value could be reset in the interrupt handler.
>>>
>>> A write_tcs_reg_sync() would read back the value that is written and try
>>> to match it to the value written to ensure that the value is written,
>>> but if that value is different, we may see false error for same.
>>>
>>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>>> ---
>>>   drivers/soc/qcom/rpmh-rsc.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> Fixes: 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller for
>> QCOM SoCs")
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Ugh, brain-fart.  Not Signed-off-by, but:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks for the review, i will send v2 adding Fixes: tag.

Thanks,
Maulik

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation