Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4284360pxu; Wed, 9 Dec 2020 13:04:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9YO7UXz4RxC2OPH52+UVvStFsBv3efEZWWU8dKk89keRR68v+BTQfwsSY21+82QnFK6wK X-Received: by 2002:a17:906:aac1:: with SMTP id kt1mr3511179ejb.329.1607547863548; Wed, 09 Dec 2020 13:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607547863; cv=none; d=google.com; s=arc-20160816; b=VyQMFWXd7WTJV3p9W4JNct+0e6XZx1BOPI6VWgwLz6Ajqj0vgeG07AM7zLsU5lSdZJ UVhTVP91MXpBf8PQlxM6ZZ7ANoT25wl02NlUHmZ0B0MsTsB245kbPVC+SJ31spYFygp/ t5pYm5SmY4D5upeIgMVFJZSfRLv+kqXs8nOeuEiwFp1l865qjINp11jD0bhDBGlcwTIl uL2nqJDsTuNIhUGLJfSvsjgaGCpKum2K1/F40IH0uSpXp4rmcD4QYAJp/fhCH97PQE67 2TPY7XWryfCIfHJr8NQFNr4iAJzaE77WiIBVwQHMMqe2FFTSalkDN3ZYV1BvtAY6WsxT bFbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=pYWbWncWHL5hPUtr0/h39G2nFyFj5DZJ+1NpptfUOGE=; b=EZ8dJ2VVRmhqHqGKyxxGtDnf1M2qP2lp28bZpyWbsx00mKmtL4q2ZnG2lhR3KAtaT4 IFy3+2vhrDIylLuhvCqyr54eNzGsiHVrhQpS9oTIhQ2uoQtn395sZHbujWF1yamH9eW8 +hv0qvWgo9CPcz+R9lKRGAeSZbQpChUCMec6nSld2Jn+xEzq6RiDothpwQVdTwV/Pgm3 058DOVnmvvgDsOUKtNO2ikfdGvQxzYSBabDijf0hoorJwrXEKncGIGOlv1kJ5Yg7CEKB 75dKS7Muwcz8MRM+ooEmoolu2sGc+kub4MA2q3HyEknj7q3/6ho9hMVzOY/uKLP1mFX/ u51w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qT81RrUe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yr3si1365140ejb.190.2020.12.09.13.04.00; Wed, 09 Dec 2020 13:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qT81RrUe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732158AbgLIVAQ (ORCPT + 99 others); Wed, 9 Dec 2020 16:00:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728183AbgLIVAD (ORCPT ); Wed, 9 Dec 2020 16:00:03 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C973C0613D6; Wed, 9 Dec 2020 12:59:23 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id d2so1918036pfq.5; Wed, 09 Dec 2020 12:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pYWbWncWHL5hPUtr0/h39G2nFyFj5DZJ+1NpptfUOGE=; b=qT81RrUelSi4/9CGafxmK+ntZGoAphMgJz0lBOeFpN3C60ZLVZglbdD1va6XQWsZlX 2WCX4IBP+W4m0JM3FvevJc050fRyP9kdAUPqRi9p9jkLvWiTA/YVHjLxhI1eHYlIGg6M B+NNGssSvi1qsa54mziU8lbu8JCSuZi/FA3msuK40BX+B9UcqRtHVPEW2imISObDrBV+ BUqB024a9NyQEFiVSvAShjT4gbCCFtH4JqBTOw8i5WnTeeRWHsidllpZ5UckgW/4pmsd dw1DLTaQ5mzOWw+qSee0Ku5S0TXglz06ZHSaUezYzGCrZUxjrXM68rdwn2GTMRaHoH1F AlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pYWbWncWHL5hPUtr0/h39G2nFyFj5DZJ+1NpptfUOGE=; b=Lk98twughkZQnxWKKIbkMTwbLHEiU2WrCYD795/cUlMqIRlYx9719wWH5rfT3HjsrO hbvAi8IU34AqcMdkt/eOXzgp87GHF79+UHjWOcP1dvslznEWUH8+q0kWG/5mY11jzNAO QIXL93eLZ5hZbWSiQiTKbanWLoeI2tX+4hFej97s0q7/Or+V8YMPuWR7KQs3dPDfc3aP 2oqoBcZAIBjofa5GXFaAyxX77FzDNZIYlyYqWw5YwvYk2jynOMrTJdWSi664+EY+xS+J FBRsRcDxVhglk0d+t3J2ykyYTt8iMfXglC4s4JTOBUyeid0LV5Xl76+G/oHe8Pc8kuev +B+w== X-Gm-Message-State: AOAM533swLLjdKqO+Fxp80Toz5SYlXXkg5IjRUDoO3LJbxgL3Vi6NOnn Tnebxvzl/2/iKhoJ4gdVR/7y8HpuPMkBSqfEYNM= X-Received: by 2002:a63:e30b:: with SMTP id f11mr3611905pgh.149.1607547562970; Wed, 09 Dec 2020 12:59:22 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> In-Reply-To: <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> From: Tony Luck Date: Wed, 9 Dec 2020 12:59:12 -0800 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Michal Kubecek Cc: Alexei Starovoitov , Justin Forbes , bpf , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 7, 2020 at 4:36 PM Michal Kubecek wrote: > Not removal, commit 3351b16af494 ("mm/filemap: add static for function > __add_to_page_cache_locked") made the function static which breaks the > build in btfids phase - but it seems to happen only on some > architectures. In our case, ppc64, ppc64le and riscv64 are broken, > x86_64, i586 and s390x succeed. (I made a mistake above, aarch64 did not > fail - but only because it was not built at all.) x86_64 fails for me: LD vmlinux BTFIDS vmlinux FAILED unresolved symbol __add_to_page_cache_locked make: *** [Makefile:1170: vmlinux] Error 255