Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <3bed61807fff6268789e7d411412fbc5cd6ffe2a.1607507863.git.hns@goldelico.com>
 <CAGngYiVKHoXPGxmScCnb-R6xoo9GNw5pG8V8Cpyk3meoJbskiw@mail.gmail.com>
 <3FA1D050-3BD5-4A97-9D83-520CCF75D147@goldelico.com> <CAGngYiVL9M72hFRWnmT_8RRX9pUTSLsNuYz6mUo0Be4Vivk7Xw@mail.gmail.com>
 <20201209210133.44ab9c97@aktux> <09D41BD9-F6BA-4566-8151-ACB3B2274B52@goldelico.com>
In-Reply-To: <09D41BD9-F6BA-4566-8151-ACB3B2274B52@goldelico.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Wed, 9 Dec 2020 16:28:12 -0500
Message-ID: <CAGngYiU3DptnURBH=xf0eO4ZtKMH1sd2qWQqfBNbDkXDpzwGeg@mail.gmail.com>
Subject: Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and
 gpio descriptors
To:     "H. Nikolaus Schaller" <hns@goldelico.com>
Cc:     Andreas Kemnade <andreas@kemnade.info>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        linux-gpio@vger.kernel.org,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>, kernel@pyra-handheld.com,
        Lukas Wunner <lukas@wunner.de>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Maxime Ripard <maxime@cerno.tech>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 9, 2020 at 3:08 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> But I have tested with
>
> > spi->mode |= SPI_MODE_3;
>
> which should keep the mode intact. Right? That did not work either.
>

- make sure ("spi: fix client driver breakages when using GPIO descriptors")
  is in your tree
- your panel's CS is active-low, so 'spi-cs-high' should be removed from its
  devicetree entry. In accordance with the rules as explained in commit
  message of 6953c57ab172. Also in accordance with the table you posted
  in this patch.

When these two changes in place, your panel should work. I have tested this
by mirroring your setup on my board:

spi5-gpio {
       compatible = "spi-gpio";
       #address-cells = <0x1>;
       #size-cells = <0x0>;
       pinctrl-names = "default";
       pinctrl-0 = <&...>;

       sck-gpios = <&gpio... GPIO_ACTIVE_HIGH>;
       miso-gpios = <&gpio... GPIO_ACTIVE_HIGH>;
       mosi-gpios = <&gpio... GPIO_ACTIVE_HIGH>;
       cs-gpios = <&gpio... GPIO_ACTIVE_HIGH>;
       num-chipselects = <1>;

       ethernet-switch@0 { /* active low cs */
               compatible = "micrel,ksz8795";
               spi-max-frequency = <1000000>;
               reg = <0>;
       };
};

If this does not work for you, then what are we missing?