Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: eeWAmNQrEcjMzbzmB01+W9YAMBN2ap/K+++gnrS3lDT2ruv0Wbiu8tSTS2jnMWkbzDeqcPM+np
 WgqxOLF0hbMA==
IronPort-SDR: vJ/l+pPM9IFmjK8VOige/gN0vTME8uNsObGeBwdVyMFb2t7EiqXXLn/UggkeuJLCgoCdbee2v6
 sXP1qI2RUwiw==
From:   "Wong, Vee Khee" <vee.khee.wong@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45
 PHY devices
Thread-Topic: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45
 PHY devices
Thread-Index: AQHWzhy9kED+u7UURU6fsJ4HgthDb6nu7xyAgABriKA=
Date:   Wed, 9 Dec 2020 22:36:43 +0000
Message-ID: <BYAPR11MB28704A7CCBAB9DF38E26EFC4ABCC0@BYAPR11MB2870.namprd11.prod.outlook.com>
References: <20201209111933.16121-1-vee.khee.wong@intel.com>
 <20201209160927.GC2602479@lunn.ch>
In-Reply-To: <20201209160927.GC2602479@lunn.ch>
Accept-Language: en-GB, en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e3a43aeb-e21f-4782-d308-08d89c92e756
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 22:36:43.2271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z0oKShV8SVWZx6R9l9UHeq1CNfVgWgF1KnkpUBAfe5S0wNrrlc4ANhHz9kXuNEKSgY04pAOhxpaXtEzKxg/asQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3285
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, December 10, 2020 12:09 AM
> To: Wong, Vee Khee <vee.khee.wong@intel.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
> <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David
> S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> Maxime Coquelin <mcoquelin.stm32@gmail.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Ong, Boon Leong <boon.leong.ong@intel.com>;
> linux-stm32@st-md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for
> C45 PHY devices
>=20
> On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote:
> > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
> > This extends the probing of C45 PHY devices on the MDIO bus.
> >
> > Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > index b2a707e2ef43..9f96bb7d27db 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> >  		memcpy(new_bus->irq, mdio_bus_data->irqs,
> sizeof(new_bus->irq));
> >
> >  	new_bus->name =3D "stmmac";
> > +	new_bus->probe_capabilities =3D MDIOBUS_C22_C45;
>=20
> It looks like this needs to be conditional on the version. xgmax2
> supports C45. And gmac4. But other versions don't.
>=20
> 	 Andrew

I will send a v2 with conditional checking for gmac4.
I do not have a xgmac2 hardware setup to test this.