Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] drivers: net: ionic: simplify the return
 expression of ionic_set_rxfh()
To:     Zheng Yongjun <zhengyongjun3@huawei.com>, drivers@pensando.io,
        davem@davemloft.net, kuba@kernel.org, leon@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201208135353.11708-1-zhengyongjun3@huawei.com>
From:   Shannon Nelson <snelson@pensando.io>
Message-ID: <9275ad90-ee7e-6e23-6a33-bb0f7a2e2eeb@pensando.io>
Date:   Wed, 9 Dec 2020 10:02:51 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.1
MIME-Version: 1.0
In-Reply-To: <20201208135353.11708-1-zhengyongjun3@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 12/8/20 5:53 AM, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Acked-by: Shannon Nelson <snelson@pensando.io>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 35c72d4a78b3..0832bedcb3b4 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -738,16 +738,11 @@ static int ionic_set_rxfh(struct net_device *netdev, const u32 *indir,
>   			  const u8 *key, const u8 hfunc)
>   {
>   	struct ionic_lif *lif = netdev_priv(netdev);
> -	int err;
>   
>   	if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP)
>   		return -EOPNOTSUPP;
>   
> -	err = ionic_lif_rss_config(lif, lif->rss_types, key, indir);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return ionic_lif_rss_config(lif, lif->rss_types, key, indir);
>   }
>   
>   static int ionic_set_tunable(struct net_device *dev,