Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Dec 2020 14:37:09 -0800
From:   Brian Norris <briannorris@chromium.org>
To:     Evan Benn <evanbenn@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use
 EC_HOST_EVENT_MASK not BIT
Message-ID: <X9FRlTDVXtj6uFQb@google.com>
References: <20201209220306.1.I6133572c0ab3c6b95426f804bac2d3833e24acb1@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201209220306.1.I6133572c0ab3c6b95426f804bac2d3833e24acb1@changeid>
Precedence: bulk

On Wed, Dec 09, 2020 at 10:03:54PM +0000, Evan Benn wrote:
> The host_event_code enum is 1-based, use EC_HOST_EVENT_MASK not BIT to
> generate the intended mask. This patch changes the behaviour of the
> mask, a following patch will restore the intended behaviour:
> 'Add LID and BATTERY to default mask'
> 
> Fixes: c214e564acb2ad9463293ab9c109bfdae91fbeaf

Normally the short hash + commit title are used here, so:

Fixes: c214e564acb2 ("platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs")

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes

With luck, maintainers can fix that up when applying, so you don't need
to resend.

Otherwise, both patches look good to me, thanks!

Reviewed-by: Brian Norris <briannorris@chromium.org>