Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4394139pxu; Wed, 9 Dec 2020 16:28:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxh8ky3/gkBcSnCymaRg+JyeL2Bea2OtYiOvkklvvKtfJemao5zfaE67nmraVj0TJgFAzpv X-Received: by 2002:a17:906:2445:: with SMTP id a5mr4294754ejb.330.1607560098068; Wed, 09 Dec 2020 16:28:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607560098; cv=none; d=google.com; s=arc-20160816; b=AMl4Z8F7x4d1RQSQWoWQLJI527cIvGXEzasKGYbN33Aw95T/fI0PRAiX+8azFAfJ4T UtKu79qOb0HvjwmH2WhaDVNdp9qGAiHOum8VHjYNYjCLJA41OBG4VK8xny0uJUOaqsSa Kw0BVXJ0NHKBdaLIQsHIQMcPhSbXFYo0FBPTAAgzXMtGGNEM+A1H1iLkh6qeXGDN5Ink Pq65NF8vwr/mov7zusy92wSxb0F5ricSZg8eLx5bUGEaNJSus7YDe7oLE7DYck0ZcJWy 6A741776fd82hJinOKTKIMvgNJbF/W58MjQyE3KDgBC4O7N7q15tjSt/TSkltCUX92C6 +YUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:references:in-reply-to :cc:to:from; bh=q4hX6+058mt1Lnadre1JApR/kKn7o1gRimywWZcbshg=; b=VXJJB0Le70rBlp0r6m7Seaqi6WgTG5MltbFfnMmgmqEJhRaQ+kv13+3Zme0beG4wax l9Px8xD9tJcue46l4m69Em2B3JACtawuOT58UjP1NQBhIaC2mSJ4rCupSWhA3YY1I+ov 4S1kza3mVYOQgD4vRixFvkhNMsnqhzF28rVZUg+O9CekmJTsF2bTHEZE0l7wMDX8Kg/h ttC1jhLqhkpsPM15tGYwdlFPPCGO3w6Ph2wrWqhlu6UOg0Kx0NRrpI5kNvcWHPtHmnmZ ciszJ3+hjE1soBuNG1MbeXC/EspBzzuGEZNwJriDfXfqxLW3pCjMbId4tKEEpzGx26hj xiXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si1514065ejr.740.2020.12.09.16.27.55; Wed, 09 Dec 2020 16:28:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730850AbgLJAYw (ORCPT + 99 others); Wed, 9 Dec 2020 19:24:52 -0500 Received: from ozlabs.org ([203.11.71.1]:51705 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727048AbgLJAYk (ORCPT ); Wed, 9 Dec 2020 19:24:40 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 4CrvmF6kJfz9sWL; Thu, 10 Dec 2020 11:23:57 +1100 (AEDT) From: Michael Ellerman To: akpm@linux-foundation.org, hch@lst.de, Michael Ellerman , Christophe Leroy , viro@zeniv.linux.org.uk, Benjamin Herrenschmidt , Paul Mackerras Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <18bcb456d32a3e74f5ae241fd6f1580c092d07f5.1607360230.git.christophe.leroy@csgroup.eu> References: <18bcb456d32a3e74f5ae241fd6f1580c092d07f5.1607360230.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH v2] powerpc/mm: Fix KUAP warning by providing copy_from_kernel_nofault_allowed() Message-Id: <160755982586.1285738.12667869391229651303.b4-ty@ellerman.id.au> Date: Thu, 10 Dec 2020 11:23:57 +1100 (AEDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2020 16:58:01 +0000 (UTC), Christophe Leroy wrote: > Since commit c33165253492 ("powerpc: use non-set_fs based maccess > routines"), userspace access is not granted anymore when using > copy_from_kernel_nofault() > > However, kthread_probe_data() uses copy_from_kernel_nofault() > to check validity of pointers. When the pointer is NULL, > it points to userspace, leading to a KUAP fault and triggering > the following big hammer warning many times when you request > a sysrq "show task": > > [...] Applied to powerpc/fixes. [1/1] powerpc/mm: Fix KUAP warning by providing copy_from_kernel_nofault_allowed() https://git.kernel.org/powerpc/c/5eedf9fe8db23313df104576845cec5f481b9b60 cheers