Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4466141pxu; Wed, 9 Dec 2020 18:55:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwqdMSwtBsqYe+r8IYLZ36RRJeEgZZ8ji/1W31kUHE/9GtKHtdhMZoDDq6MySheD41Dia2 X-Received: by 2002:a17:907:da7:: with SMTP id go39mr4787546ejc.58.1607568912967; Wed, 09 Dec 2020 18:55:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607568912; cv=none; d=google.com; s=arc-20160816; b=UCKGaIz6k02Ws6Thxg/dpydTT8/5LbohmZqAPc+q8BTo4bduNh33APdGRCnfNz+6Fu 8qk3KmJ7AOCNz9J2X1CEluoPf4qPaBN31HKD2OHHlE2/mb2ppdXI38RilbhNlauqFt0o nY65wsnZoAyIj0Y6U0RRYBiF+GWCI2X8B+GIpp3rmPVArGm9Ut1WQaPKB8g/8k84dl06 fL2pycbVHX2jhUv6UGPvDPL5VpapFBWQA2ih5cVwE6M45KUNPA1K+EUsvjt5XiZCL5yN OQvOGHZ1SUllmU1tHptWhS90xLn7BI7hGJ2aIgApZU0hf8yBgOYQ/P0cCNW9RYRUSWx3 5RTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=MgsQAo7ptWV4XpZrwWbYZLdNr5VF7O9yJnEK+K9ay0E=; b=mteQnM2k5cWb6RcYHNJX4f88+QlGy/vPJZ6YOJtUDi14uHi/s8RxO3g8K9jhPsbVJQ nwSjbs/JEpkjsC4y9DP/wEm7Nl1MY4TjjlLX9CQJOFGil89/LORjAPAnTsRPVjs34ii8 EBgjk8m77bGg5mICtORTqA71JgVz20an1xqMZBAJRYOiJ70h8WpMiRpGVRNYq0/hCX5q kEC2HWSWdu4q7OIejms0fmj6v0pxVMsnUhGAULm+yJfM8Iqbsrtk7MoxndltAVf7zPTI jeWsr71tPOMEltCGihwaeGzSzZALQ6ieIURIPbJDt1OZqs+Sybc8ti3rjb2YBKpvBh7D FHiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z9i631HD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r14si1626035eju.173.2020.12.09.18.54.49; Wed, 09 Dec 2020 18:55:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z9i631HD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729010AbgLJChF (ORCPT + 99 others); Wed, 9 Dec 2020 21:37:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:41792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgLJChF (ORCPT ); Wed, 9 Dec 2020 21:37:05 -0500 Date: Wed, 9 Dec 2020 18:36:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607567785; bh=XvfNSBjtRQDwTQaWQYMVMSpT8H8nutp1mjAcQR7vP6Q=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=Z9i631HDe1R5jmoeOhXA3++25nKEC+BRYA5F0FDi7zEdV8m6hVveolSt2t+AYiDeb BrIfrbaAFU1attLpFoEnDkLbBp9A5TZCZpr0T6wTmAKOx7vq23trf36rOisG3LCu4g Iiw2tgeTCsbq69cGwJD84zvIoGWxj+a2L59ElcS4= From: Andrew Morton To: Anton Altaparmakov Cc: "linux-ntfs-dev@lists.sourceforge.net" , LKML , Zheng Zengkai Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' Message-Id: <20201209183623.b26e90de3d0aa92a72010ff0@linux-foundation.org> In-Reply-To: <94ED375C-C57C-464B-A1CA-BFB1EEF71BB2@tuxera.com> References: <20200312041353.19877-1-zhengzengkai@huawei.com> <94ED375C-C57C-464B-A1CA-BFB1EEF71BB2@tuxera.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov wrote: > Can you please apply this? > > ... > > > --- a/fs/ntfs/logfile.c > > +++ b/fs/ntfs/logfile.c > > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) > > * optimize log_page_size and log_page_bits into constants. > > */ > > log_page_bits = ntfs_ffs(log_page_size) - 1; > > - size &= ~(s64)(log_page_size - 1); > > + size &= ~(s64)(log_page_mask); > > /* > > * Ensure the log file is big enough to store at least the two restart > > * pages and the minimum number of log record pages. https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/ addressed this?