Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable
 'log_page_mask'
To:     Anton Altaparmakov <anton@tuxera.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     "linux-ntfs-dev@lists.sourceforge.net" 
        <linux-ntfs-dev@lists.sourceforge.net>,
        LKML <linux-kernel@vger.kernel.org>
References: <20200312041353.19877-1-zhengzengkai@huawei.com>
 <94ED375C-C57C-464B-A1CA-BFB1EEF71BB2@tuxera.com>
 <20201209183623.b26e90de3d0aa92a72010ff0@linux-foundation.org>
 <C1D18C59-3E1B-4825-881C-B7AE6FACF4D7@tuxera.com>
From:   Zheng Zengkai <zhengzengkai@huawei.com>
Message-ID: <3b12e860-273e-c915-cd18-637668762107@huawei.com>
Date:   Thu, 10 Dec 2020 14:17:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <C1D18C59-3E1B-4825-881C-B7AE6FACF4D7@tuxera.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Anton and Andrew,

> Hi Andrew,
>
> Ah, oops!  Thank you and apologies.  Quite right the alternative patch was even better.  No need to apply this patch after all...
>
> Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense.
>
> Best regards,
>
> 	Anton
>
>> On 10 Dec 2020, at 02:36, Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov <anton@tuxera.com> wrote:
>>
>>> Can you please apply this?
>>>
>>> ...
>>>
>>>> --- a/fs/ntfs/logfile.c
>>>> +++ b/fs/ntfs/logfile.c
>>>> @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp)
>>>> 	 * optimize log_page_size and log_page_bits into constants.
>>>> 	 */
>>>> 	log_page_bits = ntfs_ffs(log_page_size) - 1;
>>>> -	size &= ~(s64)(log_page_size - 1);
>>>> +	size &= ~(s64)(log_page_mask);
>>>> 	/*
>>>> 	 * Ensure the log file is big enough to store at least the two restart
>>>> 	 * pages and the minimum number of log record pages.
>> https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/
>> addressed this?
>>
It's ok, thank you all the same!