Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: A8plzeTI99yx2NMo8piJ3zFmDrF0pDWRwm9miC/VeBSPgj9SnXUzeEwEfhmgNTiPmBo0zgWcXY
 pz4Nbz2AmMmXpaEJYa8nNOXmaulZKhv9ywtBt+YHYbne/ZibFeD2C0Ok+Bb4xZ2BNXmi5ubDXM
 bFjy79NdYw/aHVfgGcT+Zyb1bB7Cf6Dob7BoQWX/xzQWtz+SyNRI0dpcGZinmn9im34WFr1Ihm
 GgrsNzBVUmdquA49VKwv1oNVr7R1FZ/XJm+tj0Pl/4LpRDXffxSfMqsvVcW8XMwJi249xg11Kg
 5lI=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Xianting Tian <tian.xianting@h3c.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
CC:     "ming.lei@redhat.com" <ming.lei@redhat.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void
Thread-Topic: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void
Thread-Index: AQHWzrqYK2RyrJ+Y0US02gsJbT8PFw==
Date:   Thu, 10 Dec 2020 06:21:07 +0000
Message-ID: <BYAPR04MB4965FC5A5F69F18A1F0BB06486CB0@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20201210055307.1024-1-tian.xianting@h3c.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 756aa618-c191-4294-9fc9-08d89cd3c7f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 06:21:07.6790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GkNjeUG+DxXEmD1n1MrYT+QTf2dFKpdvO2LNUZP/NPSNkBFC6c8RXI2lIZ8teCFIlHAFDrFjdUFg8JicACjcciceEY/fXNtEx+a+6t4/b14=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7694
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/9/20 22:06, Xianting Tian wrote:=0A=
> As no one cares about the return value of blk_mq_tag_busy() and=0A=
> __blk_mq_tag_busy(), so make them return void.=0A=
>=0A=
> Other change is to simplify blk_mq_tag_idle().=0A=
>=0A=
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>=0A=
> Reviewed-by: Ming Lei <ming.lei@redhat.com>=0A=
> ---=0A=
>  block/blk-mq-tag.c |  4 ++--=0A=
>  block/blk-mq-tag.h | 16 ++++++----------=0A=
>  2 files changed, 8 insertions(+), 12 deletions(-)=0A=
>=0A=
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c=0A=
> index 9c92053e7..21ff7d156 100644=0A=
> --- a/block/blk-mq-tag.c=0A=
> +++ b/block/blk-mq-tag.c=0A=
> @@ -21,7 +21,7 @@=0A=
>   * to get tag when first time, the other shared-tag users could reserve=
=0A=
>   * budget for it.=0A=
>   */=0A=
> -bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)=0A=
> +void __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)=0A=
>  {=0A=
>  	if (blk_mq_is_sbitmap_shared(hctx->flags)) {=0A=
>  		struct request_queue *q =3D hctx->queue;=0A=
> @@ -36,7 +36,7 @@ bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)=0A=
>  			atomic_inc(&hctx->tags->active_queues);=0A=
>  	}=0A=
>  =0A=
> -	return true;=0A=
> +	return;=0A=
if above return is the last statement then you need to remove that=0A=
instead of using return with no value.=0A=
=0A=
Also, please add the version history.=0A=