Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Randy Dunlap <rdunlap@infradead.org>,
        Pawel Laszczak <pawell@cadence.com>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: linux-next: Tree for Dec 9 (usb/cdns3)
Thread-Topic: linux-next: Tree for Dec 9 (usb/cdns3)
Thread-Index: AQHWzo/azlCvSJB/Aky2bACp1E8uPqnwBkKA
Date:   Thu, 10 Dec 2020 08:52:17 +0000
Message-ID: <20201210085147.GB2388@b29397-desktop>
References: <20201209214447.3bfdeb87@canb.auug.org.au>
 <7e4ff29c-9fa8-219c-a17d-e9be9a2a92ab@infradead.org>
In-Reply-To: <7e4ff29c-9fa8-219c-a17d-e9be9a2a92ab@infradead.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.9.4 (2018-02-28)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9C7F5C2A6B36F540B5A9B226245087D8@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 01418c52-f242-4178-930b-08d89ce8e5e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 08:52:17.5747
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JB5Z7IEFSmHbwDFUPJEiXdnNlIC/VWoSnSnPUBcv+ahRmNM9xWInaxpiQCVgFAP2/87OY0JPKISYTNUqsCM4BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2373
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-12-09 16:58:16, Randy Dunlap wrote:
> On 12/9/20 2:44 AM, Stephen Rothwell wrote:
> > Hi all,
> >=20
> > Changes since 20201208:
> >=20
>=20
> (I don't know what to do about this one -- seeking help.)

Add Pawel.

Hi Pawel,

Add old cdns3 logic, when the CONFIG_USB=3Dm
If CONFIG_USB_CDNS3 is M, the host will be built as module
If CONFIG_USB_CDNS3 is build-in, the host will not built due to
USB=3Dm, so USB!=3D USB_CDNS3 at below dependency.

config USB_CDNS3_HOST
	bool "Cadence USB3 host controller"
	depends on USB=3Dy || USB=3DUSB_CDNS3

So, it has no such issue.

But after adding CDNSSP support, the configuration relationship is
much complicated, both CDNS3 and CDNSSP could choose host file,
would you have a check for this issue?

Peter

>=20
>=20
> on x86_64:
>=20
> ld: drivers/usb/cdns3/host.o: in function `xhci_cdns3_suspend_quirk':
> host.c:(.text+0x9): undefined reference to `usb_hcd_is_primary_hcd'
>=20
> This reference to 'usb_hdc_is_primary_hcd' is from hcd_to_xhci(),
> which is being built as a loadable module:
>=20
> int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> {
> 	struct xhci_hcd	*xhci =3D hcd_to_xhci(hcd);
>=20
>=20
>=20
>=20
> CONFIG_USB_GADGET=3Dy
> CONFIG_USB_SUPPORT=3Dy
> CONFIG_USB_COMMON=3Dy
> # CONFIG_USB_CONN_GPIO is not set
> CONFIG_USB_ARCH_HAS_HCD=3Dy
> CONFIG_USB=3Dm
>=20
> CONFIG_USB_CDNS_SUPPORT=3Dy
> CONFIG_USB_CDNS_HOST=3Dy
> CONFIG_USB_CDNS3=3Dm
> CONFIG_USB_CDNS3_GADGET=3Dy
> CONFIG_USB_CDNS3_HOST=3Dy
>=20
> Problem is mostly that CONFIG_USB=3Dm and CONFIG_USB_GADGET=3Dy.
>=20
>=20
> Full randconfig file is attached.
>=20
>=20
> thanks.
> --=20
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@infradead.org>


--=20

Thanks,
Peter Chen=