Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4640160pxu; Thu, 10 Dec 2020 01:30:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZx8J8QQJ2YGqxfTq4lXFVZrRTJIIl+x5EOB2UlWLc0k9KlntQkmWSObCjusay+yvT/pgZ X-Received: by 2002:aa7:c3cf:: with SMTP id l15mr5986866edr.282.1607592625395; Thu, 10 Dec 2020 01:30:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607592625; cv=none; d=google.com; s=arc-20160816; b=kFaRd3jfXNUsPcJ5OY8Npwcoys0Pw6Q4ePgbzulV5b1S7c/fa2Z6dt2XHAIHTdFZN3 dv9YJztRehGf5KU7L5zrl/Kc4meh2NUW7J7Um6/tm3IT0KUXTyJ6hfaJnrUyFMfBGU9l 1ywYBhz6INL0SNQZPjsHtVdBc/XxeXtRFb5428yzOJeRBuQwzkrm5BbkGqtORvqkrTaV 7ksmxp/9oBGhxBbf8ZjE5qM1uEbyy3Mh/K7LIvx/WpxlbCI06A5m9v2dS2OqbF4z+UOf npYv2zRAIbKOdR+jwrsL5m4za818YGbmkAlHqXfhFku6SlxaybcxktOZfMHTI3/5wyzo VIbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=UdtlpHZBgrrZDwzW8UbexqFV/jgtHelJc6bJltM0f5I=; b=UYwHIjz/0TKRB4Aq7W0aqkhujrLV9wEwTm532IhDbIpf62DRZB+wiCUaEoj+w5uE9v uq06ehsgzdi1jybu+Ms4L4MkXmQvpbtUSF/T+Jw+qMSBCrRxqZTmEBqUOaqTDBaPtvH6 gCzUyB8+h7r7JZ4CRTRnbrsxDAtFMAPEw3YK6mZ2iYshftNstz6EXl5pBEoxeSvvEe8m HXUM3YGNUa/uW4UaetGRxbvDH+kDtJiY01G5w5UylxZXkZB60cPS4/YBgUVsKrM8Mpc4 utzm7j7G+qMlEgTlDv3RMgdkmIi55bv5lUbWF0OJ67xLl3CIWjXTh1oyf4uvJmHCGS9C g2WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=S46lt3jy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k16si2343138edr.236.2020.12.10.01.30.02; Thu, 10 Dec 2020 01:30:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=S46lt3jy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730121AbgLJJ2Y (ORCPT + 99 others); Thu, 10 Dec 2020 04:28:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:38930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgLJJ2X (ORCPT ); Thu, 10 Dec 2020 04:28:23 -0500 Date: Thu, 10 Dec 2020 10:28:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607592463; bh=ALsu4fv9LUiXbofV9loYFZ/nlLyNOedi/phCg2wg4rA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=S46lt3jyJFpy8iVMc0TVwN5okhxSQd+4Ux13XmKk/d5B/yn92N5eI0KVIjbVf5HFz 2QSeX0hHyxcHyDyN70FT7nVregU8s68f7/+oOdAUyF47RTV1AZdms65w1DhsfrxhIg aoyjuWvVEvklkvZB41AN0L8YT815Zx3m56mLC7Xg= From: Greg KH To: Mike Rapoport Cc: Andrew Morton , Andrea Arcangeli , Baoquan He , David Hildenbrand , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memblock: enforce overlap of memory.memblock and memory.reserved Message-ID: References: <20201209214304.6812-1-rppt@kernel.org> <20201209214304.6812-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209214304.6812-2-rppt@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2020 at 11:43:03PM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > memblock does not require that the reserved memory ranges will be a subset > of memblock.memory. > > As the result there maybe reserved pages that are not in the range of any > zone or node because zone and node boundaries are detected based on > memblock.memory and pages that only present in memblock.reserved are not > taken into account during zone/node size detection. > > Make sure that all ranges in memblock.reserved are added to memblock.memory > before calculating node and zone boundaries. > > Fixes: 73a6e474cb37 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") > Reported-by: Andrea Arcangeli > Signed-off-by: Mike Rapoport > --- > include/linux/memblock.h | 1 + > mm/memblock.c | 24 ++++++++++++++++++++++++ > mm/page_alloc.c | 7 +++++++ > 3 files changed, 32 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.