Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201210085505.21575-1-a@unstable.cc>
In-Reply-To: <20201210085505.21575-1-a@unstable.cc>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Thu, 10 Dec 2020 10:37:18 +0100
Message-ID: <CAHmME9pOZRtzqBELQTG6tONiWxJJU8KQhSxWST2T_ReCX3ZNYQ@mail.gmail.com>
Subject: Re: [PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()
To:     Antonio Quartulli <a@unstable.cc>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        WireGuard mailing list <wireguard@lists.zx2c4.com>,
        Netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 10, 2020 at 9:56 AM Antonio Quartulli <a@unstable.cc> wrote:
>
> The definition of IS_ERR() already applies the unlikely() notation
> when checking the error status of the passed pointer. For this
> reason there is no need to have the same notation outside of
> IS_ERR() itself.
>
> Clean up code by removing redundant notation.

Thanks for the patch. I can confirm this doesn't change the codgen at all.

I've queued this up in wireguard's staging tree, and I'll push it back
out as part of the next series.

Jason