Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@nxp.com>,
        Randy Dunlap <rdunlap@infradead.org>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: RE: linux-next: Tree for Dec 9 (usb/cdns3)
Thread-Topic: linux-next: Tree for Dec 9 (usb/cdns3)
Thread-Index: AQHWzo/azlCvSJB/Aky2bACp1E8uPqnwBkKAgAAQFvCAABVCAA==
Date:   Thu, 10 Dec 2020 11:24:10 +0000
Message-ID: <BYAPR07MB538137E487C30D74D5F9FB65DDCB0@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20201209214447.3bfdeb87@canb.auug.org.au>
 <7e4ff29c-9fa8-219c-a17d-e9be9a2a92ab@infradead.org>
 <20201210085147.GB2388@b29397-desktop>
 <BYAPR07MB5381DD2499ABD871C0E4B118DDCB0@BYAPR07MB5381.namprd07.prod.outlook.com>
In-Reply-To: <BYAPR07MB5381DD2499ABD871C0E4B118DDCB0@BYAPR07MB5381.namprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d69aab3b-b380-4f52-3ecc-08d89cfe1d8c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 11:24:10.3742
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bS6zUgGaDayWSAKbL3VjkBCow0iqOBohcoemxaBJStGHl/DWd3Iy62CESuzeUhq0QDHDC40d85lSAy0pioMXZAAeoRGYnt81PUVm/k0q1dM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR07MB8149
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2020-12-10_03:2020-12-09,2020-12-10 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 mlxscore=0
 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0
 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501
 mlxlogscore=607 clxscore=1015 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2012100076
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Peter,

>
>>
>>On 20-12-09 16:58:16, Randy Dunlap wrote:
>>> On 12/9/20 2:44 AM, Stephen Rothwell wrote:
>>> > Hi all,
>>> >
>>> > Changes since 20201208:
>>> >
>>>
>>> (I don't know what to do about this one -- seeking help.)
>>
>>Add Pawel.
>>
>>Hi Pawel,
>>
>>Add old cdns3 logic, when the CONFIG_USB=3Dm
>>If CONFIG_USB_CDNS3 is M, the host will be built as module
>>If CONFIG_USB_CDNS3 is build-in, the host will not built due to
>>USB=3Dm, so USB!=3D USB_CDNS3 at below dependency.
>>
>>config USB_CDNS3_HOST
>>	bool "Cadence USB3 host controller"
>>	depends on USB=3Dy || USB=3DUSB_CDNS3
>>
>>So, it has no such issue.
>>
>>But after adding CDNSSP support, the configuration relationship is
>>much complicated, both CDNS3 and CDNSSP could choose host file,
>>would you have a check for this issue?
>
>I can recreate this issue. I will try to resolve it.

config USB_CDNS3_HOST
        bool "Cadence USB3 host controller"
-       depends on USB=3Dy || USB=3DUSB_CDNS3
+       depends on USB=3DUSB_CDNS3
        select USB_CDNS_HOST
        help
          Say Y here to enable host controller functionality of the
@@ -110,7 +110,7 @@ config USB_CDNSP_GADGET

 config USB_CDNSP_HOST
        bool "Cadence CDNSP host controller"
-       depends on USB=3Dy || USB=3DUSB_CDNSP_PCI
+       depends on USB=3DUSB_CDNSP_PCI
        select USB_CDNS_HOST
        help
          Say Y here to enable host controller functionality of the

Peter, what about such change. It fix this issue but I need to check
It with some other kernel configurations.=20
At this moment it's the only solution which I've found but
it's introduces some limitation in CDNS3/CDNSP configuration.

>
>>
>>Peter
>>
>>>
>>>
>>> on x86_64:
>>>
>>> ld: drivers/usb/cdns3/host.o: in function `xhci_cdns3_suspend_quirk':
>>> host.c:(.text+0x9): undefined reference to `usb_hcd_is_primary_hcd'
>>>
>>> This reference to 'usb_hdc_is_primary_hcd' is from hcd_to_xhci(),
>>> which is being built as a loadable module:
>>>
>>> int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>>> {
>>> 	struct xhci_hcd	*xhci =3D hcd_to_xhci(hcd);
>>>
>>>
>>>
>>>
>>> CONFIG_USB_GADGET=3Dy
>>> CONFIG_USB_SUPPORT=3Dy
>>> CONFIG_USB_COMMON=3Dy
>>> # CONFIG_USB_CONN_GPIO is not set
>>> CONFIG_USB_ARCH_HAS_HCD=3Dy
>>> CONFIG_USB=3Dm
>>>
>>> CONFIG_USB_CDNS_SUPPORT=3Dy
>>> CONFIG_USB_CDNS_HOST=3Dy
>>> CONFIG_USB_CDNS3=3Dm
>>> CONFIG_USB_CDNS3_GADGET=3Dy
>>> CONFIG_USB_CDNS3_HOST=3Dy
>>>
>>> Problem is mostly that CONFIG_USB=3Dm and CONFIG_USB_GADGET=3Dy.
>>>
>>>
>>> Full randconfig file is attached.
>>>
>>>
>>> thanks.
>>> --
>>> ~Randy
>>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>>
>>
>>
--

Thanks
Pawel Laszczak