Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Ut5zoj7FwXankmGOR28pGzamW8iKEI6CDyEtWseIw0vPFnA+M0OGmj1Ud6x6RjRFQ6N5zFcdmU
 xWhJtSytqjKw==
IronPort-SDR: VSPww2xSyJ1jwgHSm10TH7YLDBIp3WPatk1kyCCNsdQsg+yEziz23pdrbr38sDHAgUxN2OHgCt
 6Su7XgnD1GIw==
Date:   Thu, 10 Dec 2020 13:33:34 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Simon Budig <simon.budig@kernelconcepts.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of
 electrodes
Message-ID: <20201210113334.GD4077@smile.fi.intel.com>
References: <X9FZFs3NZADoIhhH@google.com>
 <20201210100803.bfohc5fglvrwrtcz@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201210100803.bfohc5fglvrwrtcz@pengutronix.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Dec 10, 2020 at 11:08:03AM +0100, Marco Felsch wrote:
> On 20-12-09 15:09, Dmitry Torokhov wrote:

...

> >  	case EV_FT:
> >  		reg_addr->reg_threshold = EV_REGISTER_THRESHOLD;
> > +		reg_addr->reg_report_rate = NO_REGISTER;
> >  		reg_addr->reg_gain = EV_REGISTER_GAIN;
> >  		reg_addr->reg_offset = NO_REGISTER;
> >  		reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X;
> >  		reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y;
> >  		reg_addr->reg_num_x = NO_REGISTER;
> >  		reg_addr->reg_num_y = NO_REGISTER;
> > -		reg_addr->reg_report_rate = NO_REGISTER;
> >  		break;
> 
> Nit:
> Unrelated change.

I guess the motive is to get these assignments consistent between the cases.
Documentation actually allows this kind of modifications of code in one change
when them are toughly related.

-- 
With Best Regards,
Andy Shevchenko