Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Dec 2020 13:22:02 +0100
From:   'Dominique Martinet' <asmadeus@codewreck.org>
To:     Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc:     David Laight <David.Laight@ACULAB.COM>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/2] ld-version: use /usr/bin/env awk for shebank
Message-ID: <20201210122202.GA8323@nautica>
References: <1606828650-29841-1-git-send-email-asmadeus@codewreck.org>
 <69c82aee-59ec-f8d8-9546-b38f85bf08c0@arm.com>
 <20201209174252.GA27721@nautica>
 <5ca5c3bb23614af0a35f01f1e3a84ead@AcuMS.aculab.com>
 <a68a09ce-f172-bfb4-6422-b1776d798f5f@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a68a09ce-f172-bfb4-6422-b1776d798f5f@arm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

Vincenzo Frascino wrote on Thu, Dec 10, 2020:
> On 12/9/20 10:03 PM, David Laight wrote:
>> Why bother with awk?

I wanted to keep the patch minimal, I'm not opposed to rewriting but
that always potentially has more impact (although as you say, this
script is simple enough)

> > I think you can do it all in a shell function.
> > Something like:
> > 	read line
> > 	line=${line##*)}
> > 	line=${line##*version }
> > 	IFS='.-'
> > 	set $line
> > 	echo $(($1*100000000 + $2*1000000 + $3*10000))
> > 
> > That will work on any recent shell.

Works for me.


> I would suggest to revert the patch for now since we are close to the merge
> window and then maybe in -rc1 start discussing a better solution.

As far as I can see the patch is only in -next, as said earlier I'm in
favor of just dropping the patch until a decision is taken for the next
merge window (or the one after that); there's no hurry for me and
nothing to revert.

-- 
Dominique