Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <724285f7c2d2544a11adfedf89aad1f9e8c684ca.camel@kernelconcepts.de>
Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of
 electrodes
From:   Simon Budig <simon.budig@kernelconcepts.de>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org
Cc:     Marco Felsch <m.felsch@pengutronix.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-kernel@vger.kernel.org
Date:   Thu, 10 Dec 2020 13:29:46 +0100
In-Reply-To: <X9FZFs3NZADoIhhH@google.com>
References: <X9FZFs3NZADoIhhH@google.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
        boundary="=-Ws5Z8/jievU0ggPJF0Fx"
User-Agent: Evolution 3.38.1-2 
MIME-Version: 1.0
Precedence: bulk


--=-Ws5Z8/jievU0ggPJF0Fx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2020-12-09 at 15:09 -0800, Dmitry Torokhov wrote:
> Instead of using special-casing retrieval of number of X/Y electrodes
> based on the firmware, let's select default values and mark registers
> as
> non-existent on firmwares that do not support this operation.
>=20
> Also mark "report rate" register as non-existent for generic
> firmwares as
> having it set to 0 does not make sense.

Looks good.

Reviewed-by: Simon Budig <simon.budig@kernelconcepts.de>

Thanks,
        Simon
--=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0kernel concepts GmbH                 Simon Bu=
dig
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Hauptstra=C3=9Fe 16                       sim=
on.budig@kernelconcepts.de
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0D-57076 Siegen                       +49-271-=
771091-17
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0http://www.kernelconcepts.de/
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0HR Siegen, HR B 9613; Gesch=C3=A4ftsf=C3=BChr=
er: Ole Reinhardt

--=-Ws5Z8/jievU0ggPJF0Fx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQTPAwhwx6BA+WIUvUM7Y79Fd6yIcAUCX9IUugAKCRA7Y79Fd6yI
cKkNAJ9X47tIpzA9rmLDBqWaGmWwxkHwLQCfYxfIA0F9eXbYcK3JOwYMtJv/KkY=
=dH1+
-----END PGP SIGNATURE-----

--=-Ws5Z8/jievU0ggPJF0Fx--