Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4865236pxu; Thu, 10 Dec 2020 07:19:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQXJgPC3uODgXC1qG7NkcuoFrYheWrmHKUAMni9XcK+2keaxEv9FfMM/xGIUXVJB7YcC+p X-Received: by 2002:a17:906:ce51:: with SMTP id se17mr6787551ejb.314.1607613557930; Thu, 10 Dec 2020 07:19:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607613557; cv=none; d=google.com; s=arc-20160816; b=aaFzwrZmLg3HyMZDv7ct/HxC+EdhCx7eZBVp/vZv0ZJ4+sE1cxn7rs+eO817m9jNPB Y8lGofJ5IA/JN5Ad3XE9bemF+kOiXHBQ02CpJJBMePC437jE290H8+Bw1PTQ/J57uGM5 TtUnyJ5dbX071o6p5jXR9T3aKjWOxzgXvdp7l7EfIqdL4cIGkugA8GLr6FyCrrzEckJg iM+nmIPJMV/CPuTVVs3EHmmm+ReYFrl4XbH4gtqtiadzMG1cK2dgcnQGY2OZyPT+NAqw 9dEcy+huCUnCQqKLmt9W8DP6ZOQ+DsUSaziGaiq4mDRiQDSzjbdkhp4rRWoMLZnMghFK uIew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PkPjwMkHKQNzpo5i/a7r16r/pQ0RUIz0TFVIVaG0Xzg=; b=VVcxJ8w1TAFSKgFQVqslFTPTzpwGyTV3/Nzm+WcOv+2pqBWbs8yHVmrZ+BXhKRDvl1 NEnBvDt4nNc3oye2ueuSUGbLTTYNbNIEeiKy2ie/CRoeiUGN3xZwcJXf3qplRYufmsuV iwgku5nRX6ZOHQpJ8J4sSF1gBRZgZoGF7jCxIkn6jUSc7J4ImlJ9/PJYIw3vulJBq9zK kwKOsJPMIMhHYF0cWTIaRrUXZQaGCYn0zKmM2TtRhEO4zj5W/DOQEQjqocJoyktPoCJc 5M+tKm1726T0a/MOy8Iz32iSXs4pwaCigssCPJeK+PM1T7Hr6imqyAq4CyIeubBmitb/ yN+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu18si1828916ejb.272.2020.12.10.07.18.53; Thu, 10 Dec 2020 07:19:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389983AbgLJPFy (ORCPT + 99 others); Thu, 10 Dec 2020 10:05:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:39082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388977AbgLJPFb (ORCPT ); Thu, 10 Dec 2020 10:05:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E0DEFADCD; Thu, 10 Dec 2020 15:04:46 +0000 (UTC) Date: Thu, 10 Dec 2020 16:04:40 +0100 From: Mian Yousaf Kaukab To: "Rafael J. Wysocki" Cc: Mian Yousaf Kaukab , "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Ionela Voinescu , ACPI Devel Maling List , Linux Kernel Mailing List , Linux PM , Petr Cervinka Subject: Re: [PATCH 1/2] acpi: cppc: add cpufreq device Message-ID: <20201210150417.GA24136@suse.de> References: <20201210142139.20490-1-yousaf.kaukab@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 03:32:09PM +0100, Rafael J. Wysocki wrote: > On Thu, Dec 10, 2020 at 3:23 PM Mian Yousaf Kaukab > wrote: > > > > Convert cppc-cpufreq driver to a platform driver (done in a separate patch) > > and add cppc-cpufreq device when acpi_cppc_processor_probe() succeeds. > > Honestly, I prefer to drop 28f06f770454 (along with its follower) > instead of making this change. > Even if we revert 28f06f770454 there is still one more small issue that these patches fix. Currently, ACPI_PROCESSOR_DEVICE_HID is used to load cppc-cpufreq module. In case when CPPC is disabled, some cycles will be wasted in loading cppc-cpufreq module. The module will return error from the init call though so no memory is wasted. After converting to platform-driver, cppc-cpufreq module will only be loaded when the platform-device is available. BR, Yousaf