Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: jhugo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D4171C43465
Subject: Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver
To:     Greg KH <gregkh@linuxfoundation.org>,
        Hemant Kumar <hemantk@codeaurora.org>
Cc:     manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, bbhatt@codeaurora.org,
        loic.poulain@linaro.org, netdev@vger.kernel.org
References: <1607584885-23824-1-git-send-email-hemantk@codeaurora.org>
 <1607584885-23824-5-git-send-email-hemantk@codeaurora.org>
 <X9HifqAntBUBV0Ce@kroah.com>
From:   Jeffrey Hugo <jhugo@codeaurora.org>
Message-ID: <1ce7fc1a-7794-6815-ab4c-0721f0422564@codeaurora.org>
Date:   Thu, 10 Dec 2020 08:01:59 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <X9HifqAntBUBV0Ce@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/10/2020 1:55 AM, Greg KH wrote:
> On Wed, Dec 09, 2020 at 11:21:25PM -0800, Hemant Kumar wrote:
>> This MHI client driver allows userspace clients to transfer
>> raw data between MHI device and host using standard file operations.
>> Driver instantiates UCI device object which is associated to device
>> file node. UCI device object instantiates UCI channel object when device
>> file node is opened. UCI channel object is used to manage MHI channels
>> by calling MHI core APIs for read and write operations. MHI channels
>> are started as part of device open(). MHI channels remain in start
>> state until last release() is called on UCI device file node. Device
>> file node is created with format
>>
>> /dev/<mhi_device_name>
>>
>> Currently it supports QMI channel.
>>
>> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> Tested-by: Loic Poulain <loic.poulain@linaro.org>
>> ---
> 
> Can you provide a pointer to the open-source userspace program that will
> be talking to this new kernel driver please?  That should be part of the
> changelog here.

Its listed in the documentation file (patch 3 in the series).  I'm 
guessing you still want it in the change log though, so Hemant should 
probably take care of that.

-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.