Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4865866pxu;
        Thu, 10 Dec 2020 07:20:01 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwE4JcT2csx7o31oIXZyzWOf1/jY3AQTscOj0JsQo0QFRK0c/hXsmGF1lN6mTDAGsUi6UaI
X-Received: by 2002:a05:6402:22e1:: with SMTP id dn1mr7424306edb.347.1607613601778;
        Thu, 10 Dec 2020 07:20:01 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1607613601; cv=none;
        d=google.com; s=arc-20160816;
        b=NWZHOUbPXEfCPvUoqeZCnbkC5tlTnjjD2E5BRbFnLB9hQGdCNyHrdHGC1n2EmFV05h
         H2IROGrsUW8+8aVAxwYny0AU0cdk9B/2bDR1hVF3A2JO7a7Rest112QGtQT/4i1AEkxN
         K5c+/BzbzcUo8aL4LvgRwyDwSEAiHkkX9u+jAZomOTOk0guuEnIePi4rT7r2jeULjxV5
         8b2EhAhHqW6b0/dcAZ6kUGthKihT5wN3RtOJkGB/GcaLRHZkJ0kqZyZrC5yzNKfkYj2X
         IVvmjREwbp9AERInqQpEjklg96lHtXmyFjzQDZB8b2e4Q/4gq6tvieCBL6rAOZhJVnN+
         pNUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from
         :dkim-signature:date;
        bh=PHwb5R1JYEbkFPipbgcFLMmVQAEpZjaL5uycpZuTMIk=;
        b=craYWNXWB1Ww+odNT9I6VfBRJyeyeblYkKMrUNO2vkRRdmjv9R9w7ydfreuADlLka8
         9PmCZMfzCAgGK5CEAdZTtXh/X1NL52XXFHiKo9HG0xYqMhVZhU5A+hl+0q78bCwWYwDm
         cuz2VbRi22rvNhvx3t3PQA8A4tqD0ndO+melIk9kKHW0qR2GeScBcdqbxnAh9DkrqlHO
         IL7ZZMasCrxwEU4mfv4JSH7SmTe17CMDvPKWHKJRNVhKVMgdhg/nxU+vji35vDHJOFVq
         p99quMjrXdEEJ+Gss7IASnSxOpCeiSKLjraFkgjyKnKgyZl1p/Ust6mVgNTlBPV1k5E2
         YOWQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BBRxezUJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id fi11si2759482ejb.378.2020.12.10.07.19.37;
        Thu, 10 Dec 2020 07:20:01 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BBRxezUJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389830AbgLJPGe (ORCPT <rfc822;mcfarlandjb@gmail.com>
        + 99 others); Thu, 10 Dec 2020 10:06:34 -0500
Received: from mail.kernel.org ([198.145.29.99]:35850 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727766AbgLJPGW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Dec 2020 10:06:22 -0500
Date:   Fri, 11 Dec 2020 00:05:34 +0900
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1607612741;
        bh=rUc8kAAzgIPOPqDkqYodpVmwWA4T53QTUItA9JEQX1E=;
        h=From:To:Cc:Subject:References:In-Reply-To:From;
        b=BBRxezUJnM3zNgdAvq4O81fM22NGLO6WD4VT4KIBL45R0sAi6OJNS5aU0RPJuKDht
         zzn76UtpaSkcsrialYwyBtsugPN0m2FGjEW6Bg3PEEputq613IEZ6C00i6HBRvQQTu
         Xl8Q8m1RlIt6NIVK11t2rQ5d9D/dZ3ahieMLgTbQ5nquTo9T6DmbRQNLfVBR7yv3Wc
         82UE48MhuNU8JLDo/FT4F6W3uGJ1mLrJPdnlmLE5TxuWxHjlhxNPNPZPkddcDd2G9e
         /hi5QTxQoauLWg9L20PsRjHYiojVHlpsPchoTH/bhE0kIrYwLqaBJ9LbjaPLLsKoqZ
         A8buRGoPAyJvg==
From:   Keith Busch <kbusch@kernel.org>
To:     Enzo Matsumiya <ematsumiya@suse.de>
Cc:     linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: hwmon: fix crash on device teardown
Message-ID: <20201210150534.GB3645@redsun51.ssa.fujisawa.hgst.com>
References: <20201209213228.5044-1-ematsumiya@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201209213228.5044-1-ematsumiya@suse.de>
User-Agent: Mutt/1.12.1 (2019-06-15)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 09, 2020 at 06:32:27PM -0300, Enzo Matsumiya wrote:
> +void nvme_hwmon_exit(struct nvme_ctrl *ctrl)
> +{
> +	hwmon_device_unregister(ctrl->dev);
> +}

The hwmon registration uses the devm_ version, so don't we need to use
the devm_hwmon_device_unregister() here?