Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Dec 2020 17:46:43 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     linux-kernel@vger.kernel.org,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        stable@vger.kernel.org, Alexander Gordeev <agordeev@linux.ibm.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [PATCH 5.4 21/54] s390/pci: fix CPU address in MSI for directed
 IRQ
Message-ID: <X9JQ83HzuDBaGoLq@kroah.com>
References: <20201210142602.037095225@linuxfoundation.org>
 <20201210142603.083190701@linuxfoundation.org>
 <805f753f-f431-a032-383c-65130ef0b153@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <805f753f-f431-a032-383c-65130ef0b153@linux.ibm.com>
Precedence: bulk

On Thu, Dec 10, 2020 at 05:34:08PM +0100, Niklas Schnelle wrote:
> Hi Greg,
> 
> sorry to bother you but I missed that the smp_cpu_get_cpu_address()
> address used here was only added with the
> commit 42d211a1ae3b77 ("s390/cpuinfo: show processor physical address")
> which landed in v5.7-rc1. This would therefore break if ever called
> (luckily it would not be called on any shipped hardware) and
> also causes a missing declaration warning as reported by
> Naresh Kamboju thanks!
> Since this is as of now just a spec fix, as on all known hardware
> the Linux CPU Id always matches the CPU Address, I would
> recommend to simply revert the commit.

Ok, will go drop it now, thanks.

greg k-h