Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Dec 2020 18:21:22 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
        nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
        sean@mess.org, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic
 configuration
Message-ID: <X9JZEohJLGiT42lu@ulmo>
References: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="DbaDMJ+M2InmvP5d"
Content-Disposition: inline
In-Reply-To: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk


--DbaDMJ+M2InmvP5d
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote:
> Use the newer .apply function of pwm_ops instead of .config, .enable,
> .disable and .set_polarity. This guarantees atomic changes of the pwm
> controller configuration. It also reduces the size of the driver.
>=20
> Since now period is a 64 bit value, add an extra check to reject periods
> that exceed the possible max value for the 32 bit register.
>=20
> This has been tested on a Raspberry PI 4.
>=20
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
>=20
> v4: Remove a superfluous blank line
>     Remove an unneeded cast (both requested by Uwe Kleine-K=C3=B6nig)
> v3: Check against period truncation (also based on a review by Uwe)
> v2: Fix compiler error for 64 bit builds
>=20
>  drivers/pwm/pwm-bcm2835.c | 69 +++++++++++++++++------------------------=
------
>  1 file changed, 24 insertions(+), 45 deletions(-) j

Applied, thanks.

Thierry

--DbaDMJ+M2InmvP5d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/SWRIACgkQ3SOs138+
s6EiyQ//TLfupe2MvYkloXLMOdWX3A1bTym9bn0wW3871vxwbseLyYFiBIe3Gxa6
X1zk8P1MiWh/oBI4JzXU8l8qw4fUx7I/1EyRrj4rLGFKBamNqB5tgUFZMGp2XIpm
Ffxg5nwPF+UxnMn5QxarCA1AmbR02Rx4KXeLDMu0C3w4tRLpwVasQkKa8xsxF5Ut
CUKPBR4lHo/Fz56+4pWRg1XJMFaJxLbmybkqUT1HxME4Yt2ZQ66FMQRU9HyhM5ea
GjV7+WgixuNrOQDg3v34ZM2W8Ed4iXhnjUYvfyLL2plRe7nBEP7z3ff4W3S/JqmZ
pfr4jvF1uVf9d0rVlszpoVv9yIog7gkXW6/0vA2JT6Wu+g+/0CNcW7wm2xoZwCWH
oRFtocxHyp53RX7jRzqaKFBZewMDaIpiqQUTxf2wuyxGuq1agIGcCmv2uuFNSkDU
rTmlu+1c+tYANS7cHBg6X0gfcFKffsArFcRhQK8VaKTIFS8hZwt/Mwu/RC5knyyT
00M7agVg97H3p2kvGFXI6INYaS93iC2+QBkCX0TY4/j01p5zSMLxp0x3WpKvdDS+
9qByW9lFhIjPsf0VlQ5G+fzZ9JmcZUlNsw9vmx0O6Ma5PQCbr/Cw9oNgLjw6odyx
1h+ILj6NuQETtzZhKobHjECm/67/K8Up2DlrITTuewyij+aw060=
=vqd+
-----END PGP SIGNATURE-----

--DbaDMJ+M2InmvP5d--