Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] usb: musb: remove unused variable 'devctl'
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     min.guo@mediatek.com, Bin Liu <b-liu@ti.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20201124084955.30270-1-min.guo@mediatek.com>
 <c2f3f643-8514-5c4a-dd52-7abc8a6dc501@gmail.com> <X9I4L3E9EJlcPMEu@kroah.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <e59a754b-ad3e-2f8f-417a-96ddfcd3cbd3@gmail.com>
Date:   Thu, 10 Dec 2020 20:33:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <X9I4L3E9EJlcPMEu@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/10/20 6:01 PM, Greg Kroah-Hartman wrote:

[...]
>>> From: Min Guo <min.guo@mediatek.com>
>>>
>>> Remove unused 'devctl' variable to fix compile warnings:
>>>
>>>      drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
>>>      drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
>>>      but not used [-Wunused-but-set-variable]
>>>
>>> Signed-off-by: Min Guo <min.guo@mediatek.com>
>>> ---
>>> changes in v3
>>> suggested by Greg Kroah-Hartman:
>>> Add a comment.
>>>
>>> changes in v2
>>> suggested by Alan Stern:
>>> Add void before musb_read to indicate that the register MUSB_DEVCTL
>>> was intended to be read and discarded.
>>> ---
>>>   drivers/usb/musb/musbhsdma.c | 8 +++++---
>>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
>>> index 0aacfc8be5a1..2a345b4ad015 100644
>>> --- a/drivers/usb/musb/musbhsdma.c
>>> +++ b/drivers/usb/musb/musbhsdma.c
>> [...]
>>> @@ -336,7 +334,11 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
>>>   						< musb_channel->len) ?
>>>   					"=> reconfig 0" : "=> complete");
>>> -				devctl = musb_readb(mbase, MUSB_DEVCTL);
>>> +				/*
>>> +				 * Some hardware may need to read the
>>> +				 * MUSB_DEVCTL register once to take effect.
>>> +				 */
>>> +				(void)musb_readb(mbase, MUSB_DEVCTL);
>>
>>    Hm, forcibly reading DevCtl in the DMA driver... sounds quite
>> nonsensically. Lemme take a look...
> 
> What happened to your look?

   I thought I posted it the same day... Indeed, here it is, archived:

https://marc.info/?l=linux-usb&m=160621841910477

> thanks,
> 
> greg k-h

MBR, Sergei